atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Madhan Neethiraj <mad...@apache.org>
Subject Re: Review Request 62627: ATLAS-2155: Allow null value comparison for NEQ operation with String attributes
Date Wed, 27 Sep 2017 21:45:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62627/#review186487
-----------------------------------------------------------




repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java
Line 1092 (original), 1104 (patched)
<https://reviews.apache.org/r/62627/#comment263059>

    Similar updated would be needed for 'NotEquals' predicates on other datatypes as well,
right? Short, Integer, Long, Boolean, Date, ..


- Madhan Neethiraj


On Sept. 27, 2017, 8:47 p.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62627/
> -----------------------------------------------------------
> 
> (Updated Sept. 27, 2017, 8:47 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2155
>     https://issues.apache.org/jira/browse/ATLAS-2155
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Currently if the Vertex has the attribute value as null, the in-memory filter discards
the vertex. This change will allow String NEQ predicate to work with null values
> 
> 
> Diffs
> -----
> 
>   repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java 18d77ee7 
> 
> 
> Diff: https://reviews.apache.org/r/62627/diff/1/
> 
> 
> Testing
> -------
> 
> REST and curl validation
> mvn clean package was successful as well
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message