atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ashutosh Mestry <ames...@hortonworks.com>
Subject Re: Review Request 62484: ATLAS-2160: Execute Saved Searches
Date Fri, 22 Sep 2017 20:46:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62484/
-----------------------------------------------------------

(Updated Sept. 22, 2017, 8:46 p.m.)


Review request for atlas, keval bhatt and Madhan Neethiraj.


Changes
-------

Updates include:
- Added new REST APIs for execute saved search.
- Removed notion of _BASIC_ and _ADVANCED_ in REST end points & core logic.
- Minor refactoring.


Bugs: ATLAS-2160
    https://issues.apache.org/jira/browse/ATLAS-2160


Repository: atlas


Description (updated)
-------

**Implementation**

There are 2 additional APIs:
* Saved Search using _type_ and _name_.
* Saved search using _guid_.

Once _AtlasUserSavedSearch_ is executed, execute _basic_ or _advanced_ search using the _searchType_.
The results are returned in _AtlasSearchResult_ form.

**CURL**

Retrieve Saved Search:
```javascript
curl -g -X GET -u admin:admin -H "Content-Type: application/json" -H "Cache-Control: no-cache"
 "http://localhost:21000/api/atlas/v2/search/saved/Tax%20Tables"
```

Search results using saved search using search name and search type:
```javascript
curl -g -X GET -u admin:admin -H "Content-Type: application/json" -H "Cache-Control: no-cache"
 "http://localhost:21000/api/atlas/v2/search/saved/execute/Tax%20Tables"
```

Search results using saved search GUID:
```javascript
curl -g -X GET -u admin:admin -H "Content-Type: application/json" -H "Cache-Control: no-cache" 
"http://localhost:21000/api/atlas/v2/search/saved/execute/guid/18a21a1b-af61-47c6-a50a-34e8ae81dad3"
```


Diffs
-----

  webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java aed82ae0 


Diff: https://reviews.apache.org/r/62484/diff/1/


Testing (updated)
-------

**Unit tests**
Executed existing tests.

**Functional tests**
Executed APIs using CURL calls.


Thanks,

Ashutosh Mestry


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message