atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Apoorv Naik <naik.apo...@gmail.com>
Subject Re: Review Request 62455: ATLAS-2092: Upfront edgelabel creation to avoid concurrency issues
Date Thu, 21 Sep 2017 16:30:50 GMT


> On Sept. 21, 2017, 3:19 p.m., David Radley wrote:
> > graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphManagement.java
> > Line 61 (original), 61 (patched)
> > <https://reviews.apache.org/r/62455/diff/1/?file=1831803#file1831803line61>
> >
> >     I think GraphBackedMetadataRepositoryTest needs to be changed lines 178. The
logic is 
> >     
> >     boolean validated1 = assertEdge(id1, type.typeName);
> >             boolean validated2 = assertEdge(id2, type.typeName);
> >             assertTrue(validated1 | validated2);
> >             
> >     It should be: 
> >      assertTrue(validated1 && validated2);

Yeah Sarath mentioned the same previously.


> On Sept. 21, 2017, 3:19 p.m., David Radley wrote:
> > repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
> > Line 460 (original), 460 (patched)
> > <https://reviews.apache.org/r/62455/diff/1/?file=1831806#file1831806line460>
> >
> >     this comment is incorrect asis.
> >     I am unsure why this comment has been left in. I suggest leaving in the 3 comments
or removing all three lines.

Will clean up the comments


> On Sept. 21, 2017, 3:19 p.m., David Radley wrote:
> > repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
> > Line 461 (original), 461 (patched)
> > <https://reviews.apache.org/r/62455/diff/1/?file=1831806#file1831806line461>
> >
> >     I think this comment needs to explain how this solves the concurrancy problem
and what the transactional implications are of this fix.

Will add more details.


- Apoorv


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62455/#review185892
-----------------------------------------------------------


On Sept. 20, 2017, 9:55 p.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62455/
> -----------------------------------------------------------
> 
> (Updated Sept. 20, 2017, 9:55 p.m.)
> 
> 
> Review request for atlas and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-2092
>     https://issues.apache.org/jira/browse/ATLAS-2092
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> See ATLAS-2092 for the discussion
> 
> 
> Diffs
> -----
> 
>   graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphManagement.java
0db46d46 
>   graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0GraphManagement.java
ec4d6c45 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1GraphManagement.java
61dc2980 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
be6a0a06 
> 
> 
> Diff: https://reviews.apache.org/r/62455/diff/1/
> 
> 
> Testing
> -------
> 
> mvn clean package -Dberkeley-elasticsearch went through fine
> Build was done 3-4 times to ensure that the concurrency tests passed every time
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message