atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Madhan Neethiraj <mad...@apache.org>
Subject Re: Review Request 62455: ATLAS-2092: Upfront edgelabel creation to avoid concurrency issues
Date Wed, 20 Sep 2017 23:22:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62455/#review185832
-----------------------------------------------------------




repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
Line 445 (original), 445 (patched)
<https://reviews.apache.org/r/62455/#comment262185>

    Edge label should be created for arrays whose element is of type CLASS or STRUCT.



repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
Line 451 (original), 451 (patched)
<https://reviews.apache.org/r/62455/#comment262186>

    Edge label should be created for struct type attributes as well.


- Madhan Neethiraj


On Sept. 20, 2017, 9:55 p.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62455/
> -----------------------------------------------------------
> 
> (Updated Sept. 20, 2017, 9:55 p.m.)
> 
> 
> Review request for atlas and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-2092
>     https://issues.apache.org/jira/browse/ATLAS-2092
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> See ATLAS-2092 for the discussion
> 
> 
> Diffs
> -----
> 
>   graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphManagement.java
0db46d46 
>   graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0GraphManagement.java
ec4d6c45 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1GraphManagement.java
61dc2980 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
be6a0a06 
> 
> 
> Diff: https://reviews.apache.org/r/62455/diff/1/
> 
> 
> Testing
> -------
> 
> mvn clean package -Dberkeley-elasticsearch went through fine
> Build was done 3-4 times to ensure that the concurrency tests passed every time
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message