atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Radley <david...@apache.org>
Subject Re: Review Request 62109: [ATLAS-2116] : Implement tag propagation using relationships
Date Wed, 20 Sep 2017 13:43:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62109/#review185791
-----------------------------------------------------------




repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java
Lines 429 (patched)
<https://reviews.apache.org/r/62109/#comment262137>

    I amnot sure why this method is in EntityGraphRetriever. The method appears to be nothing
to do with entities. I suggest we put this method int oa stattic graph utils class and make
is static - passing in the gremlinQueryProvider.



repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java
Lines 454 (patched)
<https://reviews.apache.org/r/62109/#comment262138>

    I suggest we put out the exception message here


- David Radley


On Sept. 6, 2017, 5:59 a.m., Sarath Subramanian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62109/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2017, 5:59 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-2116
>     https://issues.apache.org/jira/browse/ATLAS-2116
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Implement propagation of classifications using relationships. When a classification is
associated with an entity the tag is propagated to all its associated entities using the tagPropagation
property in the edges. Also propagate tags, if tag is deleted or updated.
> tagPropagation properties can be NONE, BOTH, ONE_TO_TWO or TWO_TO_ONE
> propagate tags only if relationships tagPropagation property is BOTH, ONE_TO_TWO or TWO_TO_ONE.
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/atlas/EntityAuditEvent.java 904674d9 
>   dashboardv2/public/js/utils/Enums.js db2c46cf 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 365e548d 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasPropagatedClassification.java
PRE-CREATION 
>   notification/src/main/java/org/apache/atlas/notification/entity/EntityNotification.java
379e8155 
>   repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListener.java
2a1881b0 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityChangeNotifier.java
6423aeab 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java
f6aa7bbf 
>   repository/src/main/java/org/apache/atlas/util/AtlasGremlin2QueryProvider.java 33f9b7ab

>   repository/src/main/java/org/apache/atlas/util/AtlasGremlinQueryProvider.java a6025293

>   repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java d8d8d91b

>   server-api/src/main/java/org/apache/atlas/listener/EntityChangeListener.java e05a7755

>   webapp/src/main/java/org/apache/atlas/notification/NotificationEntityChangeListener.java
6eadc967 
> 
> 
> Diff: https://reviews.apache.org/r/62109/diff/3/
> 
> 
> Testing
> -------
> 
> Tested using UI and POSTMAN REST client.
> 
> Unit Tests/Integration tests - In progress
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message