atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ashutosh Mestry <ames...@hortonworks.com>
Subject Review Request 62420: ATLAS-2148: Enhancement to Saved Search
Date Tue, 19 Sep 2017 22:08:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62420/
-----------------------------------------------------------

Review request for atlas, keval bhatt and Madhan Neethiraj.


Bugs: ATLAS-2148
    https://issues.apache.org/jira/browse/ATLAS-2148


Repository: atlas


Description
-------

**Implementation**

- _DataAccess.save_ now returns entity with GUID set. Logic uses _EntityMutationResponse_
for inferring the GUID.
- REST APIs have undergone minor changes. CURL calls updated (see below).


_Please used attached JSON for the examples below._

**Retrieve List of Saved Searches**
```javascript
curl -g -X GET -u admin:admin -H "Content-Type: application/json" -H "Cache-Control: no-cache"
 "http://localhost:21000/api/atlas/v2/search/saved"
```

**Retrieve Specific Saved Searches**

```javascript
curl -g -X GET -u admin:admin -H "Content-Type: application/json" -H "Cache-Control: no-cache"
 "http://localhost:21000/api/atlas/v2/search/saved/BASIC/my_search1"
```

```javascript
curl -g -X GET -u admin:admin -H "Content-Type: application/json" -H "Cache-Control: no-cache"
 "http://localhost:21000/api/atlas/v2/search/saved/ADVANCED/my_search3"
```

**Save**
```javascript
curl -g -X POST -u admin:admin -H "Content-Type: application/json" -H "Cache-Control: no-cache"
 "http://localhost:21000/api/atlas/v2/search/saved" -d @../docs/savedSearch.json
```

**Update**
```javascript
curl -g -X PUT -u admin:admin -H "Content-Type: application/json" -H "Cache-Control: no-cache"
 "http://localhost:21000/api/atlas/v2/search/saved" -d @../docs/savedSearch.json
```

**Delete**
```javascript
curl -g -X DELETE -u admin:admin -H "Content-Type: application/json" -H "Cache-Control: no-cache"
 "http://localhost:21000/api/atlas/v2/search/saved/0d0f75ef-b101-466f-843e-60196b81c98e"
```


Diffs
-----

  addons/models/0010-base_model.json 8f38f59 
  intg/src/main/java/org/apache/atlas/model/profile/AtlasUserSavedSearch.java b0698fc 
  repository/src/main/java/org/apache/atlas/discovery/AtlasDiscoveryService.java baaee85 
  repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java ad21ee4

  repository/src/main/java/org/apache/atlas/repository/ogm/AtlasSavedSearchDTO.java 26eee20

  repository/src/main/java/org/apache/atlas/repository/ogm/DataAccess.java bc93cc6 
  repository/src/main/java/org/apache/atlas/repository/userprofile/UserProfileService.java
766d1c7 
  repository/src/test/java/org/apache/atlas/repository/userprofile/UserProfileServiceTest.java
4e83296 
  webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java ad595c8 


Diff: https://reviews.apache.org/r/62420/diff/1/


Testing
-------

**Unit tests**
Updated to reflect new logic.

**Functional tests**
>From the new UI.
CURL calls.


File Attachments
----------------

Saved Search JSON
  https://reviews.apache.org/media/uploaded/files/2017/09/19/f845e2cf-3354-48e4-bfed-76b09a581af2__savedSearch.json


Thanks,

Ashutosh Mestry


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message