atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sarath Subramanian <sar...@apache.org>
Subject Re: Review Request 62401: ATLAS-2138: Admin import calls in Atlas client
Date Tue, 19 Sep 2017 06:11:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62401/#review185648
-----------------------------------------------------------


Fix it, then Ship it!





client/src/main/java/org/apache/atlas/AtlasBaseClient.java
Lines 596 (patched)
<https://reviews.apache.org/r/62401/#comment261969>

    considering using static string:
    this(path, method, status, JSON_MEDIA_TYPE, MediaType.APPLICATION_JSON);


- Sarath Subramanian


On Sept. 18, 2017, 10:54 p.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62401/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2017, 10:54 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2138
>     https://issues.apache.org/jira/browse/ATLAS-2138
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Add import capability to the client code, will be useful for integration tests
> 
> 
> Diffs
> -----
> 
>   client/pom.xml 3afba797 
>   client/src/main/java/org/apache/atlas/AtlasBaseClient.java 602831a2 
>   repository/src/test/java/org/apache/atlas/utils/TestResourceFileUtils.java PRE-CREATION

> 
> 
> Diff: https://reviews.apache.org/r/62401/diff/1/
> 
> 
> Testing
> -------
> 
> Successful import from test code
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message