atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sarath Subramanian <sar...@apache.org>
Subject Re: Review Request 62342: [ATLAS-2136]: Change audit and notification entityChangeListener to start using v2 API structure
Date Tue, 19 Sep 2017 03:00:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62342/
-----------------------------------------------------------

(Updated Sept. 18, 2017, 8 p.m.)


Review request for atlas and Madhan Neethiraj.


Bugs: ATLAS-2136
    https://issues.apache.org/jira/browse/ATLAS-2136


Repository: atlas


Description
-------

Currently audit and notification entityChangeListeners is using v1 API. This needs to be migrated
to start using v2 APIs. This is needed for notification of tag propagation.
Also provide a new REST API to get audit events for an entity using v2 structure


Diffs (updated)
-----

  client/src/main/java/org/apache/atlas/EntityAuditEventV2.java PRE-CREATION 
  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java d205faf5 
  notification/src/main/java/org/apache/atlas/notification/entity/EntityNotificationV2.java
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java PRE-CREATION

  repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditRepository.java 9dc78350

  repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java
5a5a2c10 
  repository/src/main/java/org/apache/atlas/repository/audit/InMemoryEntityAuditRepository.java
22d2a810 
  repository/src/main/java/org/apache/atlas/repository/audit/NoopEntityAuditRepository.java
c3826019 
  repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java 5a0b74e3

  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityChangeNotifier.java
7b349c46 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java
a5db81bf 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java
f6aa7bbf 
  repository/src/test/java/org/apache/atlas/repository/audit/AuditRepositoryV2TestBase.java
PRE-CREATION 
  repository/src/test/java/org/apache/atlas/repository/impexp/ExportServiceTest.java 8eb7a510

  repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java
8d040946 
  repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1Test.java
94cc5b93 
  server-api/src/main/java/org/apache/atlas/listener/EntityChangeListener.java e05a7755 
  server-api/src/main/java/org/apache/atlas/listener/EntityChangeListenerV2.java PRE-CREATION

  webapp/src/main/java/org/apache/atlas/notification/EntityNotificationListenerV2.java PRE-CREATION

  webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 0f6eeb11 


Diff: https://reviews.apache.org/r/62342/diff/3/

Changes: https://reviews.apache.org/r/62342/diff/2-3/


Testing
-------

Validated HBase audit events and Kafka notification message for the following operations:
1. Entity Create
2. Entity Update
3. Entity Delete
4. Add Classification
5. Delete Classification
6. Update Classification

Listeners were notified using v2 API structure


Thanks,

Sarath Subramanian


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message