atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Apoorv Naik <naik.apo...@gmail.com>
Subject Re: Review Request 62338: ATLAS-2091: Special tokenizer character shouldn't be included in index query
Date Thu, 14 Sep 2017 19:35:17 GMT


> On Sept. 14, 2017, 7:34 p.m., Apoorv Naik wrote:
> > This should be extended for suffix regex matches too. And LIKE operator should match
the provided value as is (user will most likely enter a regex for LIKE)

Oops, commented on wrong review


- Apoorv


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62338/#review185444
-----------------------------------------------------------


On Sept. 14, 2017, 6:43 p.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62338/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2017, 6:43 p.m.)
> 
> 
> Review request for atlas and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-2091
>     https://issues.apache.org/jira/browse/ATLAS-2091
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Certain characters are used in tokenizing the vertex attribute values, if these are present
within the attribute value of the search parameter JSON then the index returns inconsistent
results.
> 
> Fix is to detect such violations and push down the attribute processing to the graph
query or in memory predicate.
> 
> 
> Diffs
> -----
> 
>   repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 1cb2249d 
> 
> 
> Diff: https://reviews.apache.org/r/62338/diff/1/
> 
> 
> Testing
> -------
> 
> Tested with UI and REST calls. The logs indicate that the attribute will not be processed
by index
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message