atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Madhan Neethiraj <mad...@apache.org>
Subject Re: Review Request 62110: ATLAS-2115: Fix Regression on Basic search
Date Wed, 13 Sep 2017 18:43:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62110/#review185312
-----------------------------------------------------------




repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java
Lines 286 (patched)
<https://reviews.apache.org/r/62110/#comment261622>

    This comment doesn't look right. Please review and update.



repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java
Lines 67 (patched)
<https://reviews.apache.org/r/62110/#comment261624>

    Since typeName is a single-value, 'in' predicate seems appropriate. Please review.



repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java
Line 325 (original), 400 (patched)
<https://reviews.apache.org/r/62110/#comment261631>

    this should be:
     return ((Collection)attrValue).contains(value);



repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java
Lines 526 (patched)
<https://reviews.apache.org/r/62110/#comment261630>

    this should be:
     return ((Collection)value).contains(attrVal);


- Madhan Neethiraj


On Sept. 13, 2017, 5:28 p.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62110/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2017, 5:28 p.m.)
> 
> 
> Review request for atlas and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-2115
>     https://issues.apache.org/jira/browse/ATLAS-2115
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-1880 introduced regression in call timings for the basic search GET implementation
> 
> 
> Diffs
> -----
> 
>   intg/src/main/java/org/apache/atlas/model/discovery/SearchParameters.java 972c11e3

>   repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java
0daab030 
>   repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java a4a638af

>   repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java d5e39236 
>   repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java fc973e6f 
> 
> 
> Diff: https://reviews.apache.org/r/62110/diff/4/
> 
> 
> Testing
> -------
> 
> Tested via scripts and network call timing in Chrome/Firefox.
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message