atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Madhan Neethiraj <mad...@apache.org>
Subject Re: Review Request 62030: ATLAS-2112: move the Atlas models to subfolders
Date Fri, 01 Sep 2017 21:20:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62030/#review184393
-----------------------------------------------------------



David - the updates look pretty clean. Please review and update for few minor comments. Thanks!


repository/src/main/java/org/apache/atlas/repository/store/bootstrap/AtlasTypeDefStoreInitializer.java
Line 104 (original), 110 (patched)
<https://reviews.apache.org/r/62030/#comment260576>

    "topModelsDirName" ==> "modelsDirName"



repository/src/main/java/org/apache/atlas/repository/store/bootstrap/AtlasTypeDefStoreInitializer.java
Line 109 (original), 113 (patched)
<https://reviews.apache.org/r/62030/#comment260577>

    "Types directory {} does not exist or not readable or has no typedef files" ==> "Types
directory {} does not exist or is not readable or is empty"



repository/src/main/java/org/apache/atlas/repository/store/bootstrap/AtlasTypeDefStoreInitializer.java
Lines 118 (patched)
<https://reviews.apache.org/r/62030/#comment260578>

    "topModelTypeDefFiles" ==> "modelsDirContents"



repository/src/main/java/org/apache/atlas/repository/store/bootstrap/AtlasTypeDefStoreInitializer.java
Lines 127 (patched)
<https://reviews.apache.org/r/62030/#comment260580>

    "patches" is a special name in applyTypePatches(). We should exclude processing this directory
from here; since this directory would have patch files (and not complete model files)



repository/src/main/java/org/apache/atlas/repository/store/bootstrap/AtlasTypeDefStoreInitializer.java
Lines 131 (patched)
<https://reviews.apache.org/r/62030/#comment260579>

    If "models" directory has any files, perhaps we should load these before loading sub-directory
contents?



repository/src/main/java/org/apache/atlas/repository/store/bootstrap/AtlasTypeDefStoreInitializer.java
Lines 141 (patched)
<https://reviews.apache.org/r/62030/#comment260582>

    '",typesDir' ==> '", typesDir'



repository/src/main/java/org/apache/atlas/repository/store/bootstrap/AtlasTypeDefStoreInitializer.java
Lines 142 (patched)
<https://reviews.apache.org/r/62030/#comment260581>

    "=typesDir" ==> "= typesDir"



repository/src/main/java/org/apache/atlas/repository/store/bootstrap/AtlasTypeDefStoreInitializer.java
Lines 147 (patched)
<https://reviews.apache.org/r/62030/#comment260583>

    '",typesDirName ' ==> '", typesDirName'



repository/src/main/java/org/apache/atlas/repository/store/bootstrap/AtlasTypeDefStoreInitializer.java
Line 150 (original), 184 (patched)
<https://reviews.apache.org/r/62030/#comment260584>

    '",typesDir' ==> '", typesDir'


- Madhan Neethiraj


On Sept. 1, 2017, 3:39 p.m., David Radley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62030/
> -----------------------------------------------------------
> 
> (Updated Sept. 1, 2017, 3:39 p.m.)
> 
> 
> Review request for atlas and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-2112: move the Atlas models to subfolders
> 
> 
> Diffs
> -----
> 
>   addons/falcon-bridge/pom.xml e07295de122a82621d1fda07d98139a7681b37b3 
>   addons/hive-bridge/pom.xml 8ee08818b7ec46967104811783ed646950dab8a3 
>   addons/models/0010-base_model.json  
>   addons/models/1020-fs_model.json  
>   addons/models/1030-hive_model.json  
>   addons/models/1040-sqoop_model.json  
>   addons/models/1050-falcon_model.json  
>   addons/models/1060-hbase_model.json  
>   addons/models/1070-kafka_model.json  
>   addons/models/1080-storm_model.json  
>   addons/models/patches/001-hive_column_add_position.json  
>   addons/models/patches/002-hive_column_table_add_options.json  
>   addons/models/patches/003-hive_column_update_table_remove_constraint.json  
>   addons/sqoop-bridge/pom.xml b6273b68c16cf2806ca31afb2251d00b90d4cd4e 
>   addons/storm-bridge/pom.xml a5845ed58df21a4be605c542439f0b36c0eabf78 
>   repository/src/main/java/org/apache/atlas/repository/store/bootstrap/AtlasTypeDefStoreInitializer.java
66cedd3960d3950259ae7bd991206dd6e020ac9d 
>   repository/src/test/java/org/apache/atlas/repository/impexp/ImportServiceTest.java
e1461dd2cb436cc190b4d7d1b2e91858199cd223 
>   webapp/pom.xml 2a060279b85deab1d016a3e9ac2e2e1519f09d3f 
> 
> 
> Diff: https://reviews.apache.org/r/62030/diff/1/
> 
> 
> Testing
> -------
> 
> Ran junits
> Brought up Atlas and made sure content from the models and content from the patch files
was there, byt issuing a get for all typedefs
> 
> 
> Thanks,
> 
> David Radley
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message