Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 5CBEA200CE7 for ; Thu, 17 Aug 2017 23:05:21 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 5B00A16BC7E; Thu, 17 Aug 2017 21:05:21 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id A0B5A16BC7C for ; Thu, 17 Aug 2017 23:05:20 +0200 (CEST) Received: (qmail 80032 invoked by uid 500); 17 Aug 2017 21:05:19 -0000 Mailing-List: contact dev-help@atlas.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@atlas.apache.org Delivered-To: mailing list dev@atlas.apache.org Received: (qmail 79961 invoked by uid 99); 17 Aug 2017 21:05:19 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Aug 2017 21:05:19 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 120881A1BE7; Thu, 17 Aug 2017 21:05:19 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 4.201 X-Spam-Level: **** X-Spam-Status: No, score=4.201 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id pLnICc7ZOMYZ; Thu, 17 Aug 2017 21:05:17 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id B0E165FD41; Thu, 17 Aug 2017 21:05:16 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 319C9E00A7; Thu, 17 Aug 2017 21:05:16 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 057E4C40476; Thu, 17 Aug 2017 21:05:12 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0202117642754524944==" MIME-Version: 1.0 Subject: Re: Review Request 61721: [ATLAS-2054]: Add flag to exclude attribute mapping in FullTextMapper From: Apoorv Naik To: Madhan Neethiraj Cc: Apoorv Naik , atlas , Sarath Subramanian Date: Thu, 17 Aug 2017 21:05:12 -0000 Message-ID: <20170817210512.56474.98591@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Apoorv Naik X-ReviewGroup: atlas X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/61721/ X-Sender: Apoorv Naik References: <20170817210217.56474.57116@reviews-vm2.apache.org> In-Reply-To: <20170817210217.56474.57116@reviews-vm2.apache.org> Reply-To: Apoorv Naik X-ReviewRequest-Repository: atlas archived-at: Thu, 17 Aug 2017 21:05:21 -0000 --===============0202117642754524944== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61721/#review183155 ----------------------------------------------------------- repository/src/main/java/org/apache/atlas/repository/graph/FullTextMapperV2.java Lines 251 (patched) Is this needed ? The injected configuration object can be used instead. - Apoorv Naik On Aug. 17, 2017, 9:02 p.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61721/ > ----------------------------------------------------------- > > (Updated Aug. 17, 2017, 9:02 p.m.) > > > Review request for atlas and Madhan Neethiraj. > > > Bugs: ATLAS-2054 > https://issues.apache.org/jira/browse/ATLAS-2054 > > > Repository: atlas > > > Description > ------- > > Add property in atlas-application.properties to exclude listed attributes to be excluded when mapping fulltext > > e.g. > atlas.search.fulltext.type.hive_table.attributes.exclude=profileData > atlas.search.fulltext.type.hive_column.attributes.exclude=profileData > > > Diffs > ----- > > repository/src/main/java/org/apache/atlas/repository/graph/FullTextMapperV2.java 1ed12bc0 > > > Diff: https://reviews.apache.org/r/61721/diff/1/ > > > Testing > ------- > > mvn clean package suceeded. > > > Thanks, > > Sarath Subramanian > > --===============0202117642754524944==--