Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B7EB82004F5 for ; Fri, 11 Aug 2017 11:30:03 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id B4CF116B779; Fri, 11 Aug 2017 09:30:03 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 08C9316B790 for ; Fri, 11 Aug 2017 11:30:02 +0200 (CEST) Received: (qmail 36800 invoked by uid 500); 11 Aug 2017 09:30:02 -0000 Mailing-List: contact dev-help@atlas.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@atlas.apache.org Delivered-To: mailing list dev@atlas.apache.org Received: (qmail 36685 invoked by uid 99); 11 Aug 2017 09:30:01 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 11 Aug 2017 09:30:01 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 77201C1C0C; Fri, 11 Aug 2017 09:30:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.999 X-Spam-Level: ** X-Spam-Status: No, score=2.999 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 67CrkdPc9qRD; Fri, 11 Aug 2017 09:30:00 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 2C20A5FB3A; Fri, 11 Aug 2017 09:30:00 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7DD60E02FD; Fri, 11 Aug 2017 09:29:59 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id D59B4C408B3; Fri, 11 Aug 2017 09:29:58 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0366014528861331338==" MIME-Version: 1.0 Subject: Re: Review Request 61566: ATLAS-1867: org.apache.atlas.AtlasClientV2.deleteAtlasTypeDefs gives an exception From: David Radley To: Madhan Neethiraj , David Radley , Sarath Subramanian Cc: atlas , Richard Ding Date: Fri, 11 Aug 2017 09:29:57 -0000 Message-ID: <20170811092957.13592.97676@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: David Radley X-ReviewGroup: atlas X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/61566/ X-Sender: David Radley X-ReviewBoard-ShipIt: 1 References: <20170810175602.18108.45518@reviews-vm2.apache.org> In-Reply-To: <20170810175602.18108.45518@reviews-vm2.apache.org> X-ReviewBoard-ShipIt-Only: 1 Reply-To: David Radley X-ReviewRequest-Repository: atlas archived-at: Fri, 11 Aug 2017 09:30:03 -0000 --===============0366014528861331338== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61566/#review182673 ----------------------------------------------------------- Ship it! Ship It! - David Radley On Aug. 10, 2017, 5:56 p.m., Richard Ding wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61566/ > ----------------------------------------------------------- > > (Updated Aug. 10, 2017, 5:56 p.m.) > > > Review request for atlas, David Radley, Madhan Neethiraj, and Sarath Subramanian. > > > Bugs: ATLAS-1867 > https://issues.apache.org/jira/browse/ATLAS-1867 > > > Repository: atlas > > > Description > ------- > > This patch returns the correct HTTP code ""204 No Content" instead of "200 OK" > > > Diffs > ----- > > client/src/main/java/org/apache/atlas/AtlasClientV2.java 13533571 > > > Diff: https://reviews.apache.org/r/61566/diff/1/ > > > Testing > ------- > > All unit tests pass after applying the patch. > > > Thanks, > > Richard Ding > > --===============0366014528861331338==--