Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id C5D8B20049E for ; Thu, 10 Aug 2017 18:18:30 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id C302A16B9CD; Thu, 10 Aug 2017 16:18:30 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E7C1216B9CC for ; Thu, 10 Aug 2017 18:18:29 +0200 (CEST) Received: (qmail 23578 invoked by uid 500); 10 Aug 2017 16:18:29 -0000 Mailing-List: contact dev-help@atlas.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@atlas.apache.org Delivered-To: mailing list dev@atlas.apache.org Received: (qmail 23565 invoked by uid 99); 10 Aug 2017 16:18:28 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 10 Aug 2017 16:18:28 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 60D011807F4; Thu, 10 Aug 2017 16:18:28 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3 X-Spam-Level: *** X-Spam-Status: No, score=3 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id lNfDJTbFsX9M; Thu, 10 Aug 2017 16:18:27 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 4D7F25FB2C; Thu, 10 Aug 2017 16:18:27 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id E7A6FE0051; Thu, 10 Aug 2017 16:18:26 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 76E88C400FA; Thu, 10 Aug 2017 16:18:25 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6073357935158476585==" MIME-Version: 1.0 Subject: Re: Review Request 61541: ATLAS-2037: Unit Test Failure Resolution: testConsumersAreStoppedWhenInstanceBecomesPassive From: Ashutosh Mestry To: Apoorv Naik , Nixon Rodrigues Cc: Ashutosh Mestry , atlas Date: Thu, 10 Aug 2017 16:18:25 -0000 Message-ID: <20170810161825.18100.15267@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Ashutosh Mestry X-ReviewGroup: atlas X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/61541/ X-Sender: Ashutosh Mestry References: <20170809204528.23181.78364@reviews-vm2.apache.org> In-Reply-To: <20170809204528.23181.78364@reviews-vm2.apache.org> Reply-To: Ashutosh Mestry X-ReviewRequest-Repository: atlas archived-at: Thu, 10 Aug 2017 16:18:31 -0000 --===============6073357935158476585== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61541/ ----------------------------------------------------------- (Updated Aug. 10, 2017, 4:18 p.m.) Review request for atlas, Apoorv Naik and Nixon Rodrigues. Changes ------- Updates include: - Addressed review comment. - Additional unit test to handle case where consumer is stopped before starting. Bugs: ATLAS-2037 https://issues.apache.org/jira/browse/ATLAS-2037 Repository: atlas Description ------- **Implementation** Used the _doAnswer_ to be as close to regular flow as possible. This mocks submit method and starts the _HookConsumer_ thread that was added in the previous step. Verified _wakeup_ was invoked. Diffs (updated) ----- webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java 5a982bb webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerTest.java f4ec56a Diff: https://reviews.apache.org/r/61541/diff/2/ Changes: https://reviews.apache.org/r/61541/diff/1-2/ Testing ------- **Unit tests** Executed all unit tests for _NotificationHookConsumerTest_. Thanks, Ashutosh Mestry --===============6073357935158476585==--