Mailing-List: contact dev-help@atlas.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@atlas.apache.org
Content-Type: multipart/alternative;
 boundary="===============4320098208729535388=="
MIME-Version: 1.0
Subject: Re: Review Request 61274: ATLAS-1944 - Fix for
 ConcurrentModificationException Exception in HookConsumer (KafkaConsumer)
 while stopping Atlas server
From: Nixon Rodrigues <nixon.rodrigues@freestoneinfotech.com>
To: Apoorv Naik <naik.apoorv@gmail.com>, Madhan Neethiraj <madhan@apache.org>,
 Ashutosh Mestry <amestry@hortonworks.com>,
 Sarath Subramanian <sarath@apache.org>
Cc: atlas <dev@atlas.incubator.apache.org>,
 Nixon Rodrigues <nixon.rodrigues@freestoneinfotech.com>
Date: Wed, 02 Aug 2017 08:46:39 -0000
Message-ID: <20170802084639.16836.56@reviews-vm2.apache.org>
Auto-Submitted: auto-generated
Sender: Nixon Rodrigues <noreply@reviews.apache.org>
References: <20170801201229.55935.40099@reviews-vm2.apache.org>
In-Reply-To: <20170801201229.55935.40099@reviews-vm2.apache.org>
Reply-To: Nixon Rodrigues <nixon.rodrigues@freestoneinfotech.com>
archived-at: Wed, 02 Aug 2017 08:46:45 -0000

--===============4320098208729535388==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


> On Aug. 1, 2017, 8:12 p.m., Ashutosh Mestry wrote:
> > Can you please let me know the testing performed to verify this. I am little hesitent because this removes _ShutdownableThread_.
> > 
> > See attached my patch that merely calls _shutdown_ on consumer thread. I have done some testing on this and did not see the problems we had seen before.

With calling consumer.stop(); there timeout in thread shutdown with message in log "Timed out waiting for consumer threads to shut down, exiting uncleanly"

But after Adding extended HookConsumer from ShutdownableThread and calling consumer.shutdown(), closing of kafkaconsumer was happening fine before timeout of consumer thread.Now added back the ShutdownableThread implementation.


- Nixon


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61274/#review181916
-----------------------------------------------------------


On Aug. 1, 2017, 11:07 a.m., Nixon Rodrigues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61274/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2017, 11:07 a.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-1944
>     https://issues.apache.org/jira/browse/ATLAS-1944
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Background:- NotificationHookConsumer was throwing ConcurrentModificationException exception while shutting down the consumer thread. The stop method of thread was calling the kafkacosumer.stop method while in run method of HookConsumer which is busy in cosuming the kafka message by polling kafka server. This simaltanous action of stoping and polling causes ConcurrentModificationException.
> 
> Fix:- 
> 
> * Added try finally block in run method which wraps the while loop and when loop ends the finally blocks calls the consumer close method is called which ensures that close is called after consuming is ended. 
> 
> * Replaced the ShutdownThread interface which was delaying the shutdown process of consumer with Runnable interface used earlier.
> 
> 
> Reference : - https://kafka.apache.org/090/javadoc/index.html?org/apache/kafka/clients/consumer/KafkaConsumer.html
> 
> 
> Diffs
> -----
> 
>   notification/src/main/java/org/apache/atlas/kafka/AtlasKafkaConsumer.java d431176 
>   notification/src/main/java/org/apache/atlas/notification/NotificationConsumer.java 0bd75e1 
>   notification/src/test/java/org/apache/atlas/notification/AbstractNotificationConsumerTest.java bcee00c 
>   webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java b8255b3 
> 
> 
> Diff: https://reviews.apache.org/r/61274/diff/1/
> 
> 
> Testing
> -------
> 
> Tested the Atlas kafkaconsumer from hive hook and shutdown of atlas server to check if there is issue while shutdown process.
> Unit test and integration test are passing.
> 
> 
> Thanks,
> 
> Nixon Rodrigues
> 
>


--===============4320098208729535388==--