atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Madhan Neethiraj (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (ATLAS-2083) Refactor Atlas<Type>DefStore classes to reduce code duplication
Date Mon, 28 Aug 2017 20:29:00 GMT

     [ https://issues.apache.org/jira/browse/ATLAS-2083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Madhan Neethiraj resolved ATLAS-2083.
-------------------------------------
    Resolution: Fixed

Committed to master: http://git-wip-us.apache.org/repos/asf/atlas/commit/15d67e52

[~rding] - thanks for the patch. I committed the patch with few minor updates like removal
of unused imports, typo. Please review.

> Refactor Atlas<Type>DefStore classes to reduce code duplication
> ---------------------------------------------------------------
>
>                 Key: ATLAS-2083
>                 URL: https://issues.apache.org/jira/browse/ATLAS-2083
>             Project: Atlas
>          Issue Type: Improvement
>          Components:  atlas-core
>    Affects Versions: 0.8-incubating
>            Reporter: Richard Ding
>            Assignee: Richard Ding
>             Fix For: 0.9-incubating
>
>         Attachments: ATLAS-2083_1.patch, ATLAS-2083.patch
>
>
> Currently each top-level TypeDef defines its own DefStore interface. These interfaces
have the same methods.  I suggest that we use generic interface to reduce the code duplication.
> We can also tighten the type restriction on these interfaces. Replacing Object reference
with AtlasVertex reference.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message