atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Radley (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ATLAS-2050) Add helper method in relationship store to check if entity has relationship associated
Date Thu, 17 Aug 2017 08:57:00 GMT

    [ https://issues.apache.org/jira/browse/ATLAS-2050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16130117#comment-16130117
] 

David Radley commented on ATLAS-2050:
-------------------------------------

I am not sure where this is on the review board. Some feedback:  
- if you are going to put out a debug log - I suggest moving it until after the iteration
so we can trace whether we found anything.  
- is this possible to unit test? 
- attributeName can be null and you use it in the next line
- how can relationshipDef.getEndDef1() be null ? If this is null we would put out another
validation message for this earlier. Same for endDef2.
- I guess we should make sure that relationshipDef.getEndDef1().getName() is not null and
put a=out a unique message for that as well. 
- if this get is only used for validation, we could rename to a validate name and put out
the exception message in context rather than return null. I would suggest a getter like this
would be used post validation- when we know the RelationshipDef and ends exist and are well
formed or do not exist.   

> Add helper method in relationship store to check if entity has relationship associated
> --------------------------------------------------------------------------------------
>
>                 Key: ATLAS-2050
>                 URL: https://issues.apache.org/jira/browse/ATLAS-2050
>             Project: Atlas
>          Issue Type: Improvement
>          Components:  atlas-core
>    Affects Versions: trunk, 0.9-incubating
>            Reporter: Sarath Subramanian
>            Assignee: Sarath Subramanian
>            Priority: Minor
>             Fix For: trunk, 0.9-incubating
>
>         Attachments: ATLAS-2050.1.patch
>
>
> Add helper method in AtlasRelationshipStoreV1 to check whether entity vertex has a relationship
associated with a relationship type.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message