atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sarath Subramanian <sar...@apache.org>
Subject Re: Review Request 61913: ATLAS-2012: Build docker image
Date Fri, 25 Aug 2017 18:55:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61913/#review183866
-----------------------------------------------------------




dev-support/atlas-docker/Dockerfile
Lines 40 (patched)
<https://reviews.apache.org/r/61913/#comment259930>

    I think it's okay to skipTests when building docker image, these tests run for an hour
and for people who want to quickly try atlas it might take a while.
    
    Hbase Dockerfile also skip tests: https://github.com/apache/hbase/blob/master/dev-support/hbase_docker/Dockerfile


- Sarath Subramanian


On Aug. 25, 2017, 6:14 a.m., Nigel Jones wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61913/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2017, 6:14 a.m.)
> 
> 
> Review request for atlas, Apoorv Naik, David Radley, Madhan Neethiraj, and Richard Ding.
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-2012: Build docker image
> 
> Note: Unit tests are currently not run within the docker image build process. As per
the JIRA it would be nice to include these but currently the tests fail in many ways. This
is an independent issue to the docker image work, and so I propose opening a new JIRA to re-enable
UT once build is stable, but meanwhile we can get the docker support in
> 
> 
> Diffs
> -----
> 
>   dev-support/atlas-docker/Dockerfile PRE-CREATION 
>   dev-support/atlas-docker/README.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/61913/diff/1/
> 
> 
> Testing
> -------
> 
> * check image can be rebuilt repeatedly
> * checker Atlas image starts up correctly
> * Run some unit tests in built image (note: see mailing list for discussion about current
IT test failures in builds)
> * Verified Atlas Web UI is accessible
> 
> 
> Thanks,
> 
> Nigel Jones
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message