atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Richard Ding via Review Board <nore...@reviews.apache.org>
Subject Re: Review Request 61561: ATLAS-1218: Atlas says it is started but does not accept REST requests
Date Mon, 14 Aug 2017 23:19:00 GMT


> On Aug. 11, 2017, 11:11 a.m., David Radley wrote:
> > distro/src/bin/atlas_config.py
> > Lines 71 (patched)
> > <https://reviews.apache.org/r/61561/diff/1/?file=1794995#file1794995line71>
> >
> >     I am uncomfortable duplicating the default port values here. I suggest moving
this logic to the java class that already has the default port values

The default ports are hard-coded in Java class:
```
appPort = StringUtils.isEmpty(enableTLSFlag) || enableTLSFlag.equals("true") ?
            configuration.getInt(ATLAS_SERVER_HTTPS_PORT, 21443) :
            configuration.getInt(ATLAS_SERVER_HTTP_PORT, 21000);
```
It's also difficult to access Java class from python code.


> On Aug. 11, 2017, 11:11 a.m., David Radley wrote:
> > distro/src/bin/atlas_config.py
> > Lines 454 (patched)
> > <https://reviews.apache.org/r/61561/diff/1/?file=1794995#file1794995line454>
> >
> >     is this going to work if -port was specified on the atlas_start command?

Good catch! The new patch handles -port option.


> On Aug. 11, 2017, 11:11 a.m., David Radley wrote:
> > distro/src/bin/atlas_config.py
> > Lines 473 (patched)
> > <https://reviews.apache.org/r/61561/diff/1/?file=1794995#file1794995line473>
> >
> >     I was hoping we would be able to be notified when Atlas was started or the startup
time reduced, by understanding why there is a delay and minimizing it.
> >     
> >     Once we understand that and decide that polling is the appropriate resolution
- I suggest a 1 second poll - as we can do nothing with Atlas until it is  started.

Good point. Right now the atlas_start.py script just launches a process asynchronously without
knowning when the Atlas server will complete the initialization (e.g. creating hbase tables,
solr indexes and typedefs). This solution is to let the startup script ping the endpoint of
the web server. 

I'll change the ping interval to 1 sec.


> On Aug. 11, 2017, 11:11 a.m., David Radley wrote:
> > distro/src/bin/atlas_config.py
> > Lines 475 (patched)
> > <https://reviews.apache.org/r/61561/diff/1/?file=1794995#file1794995line475>
> >
> >     I am not expert on all the ways Atlas can be started, does this work with OAuth
and does Knox work with this?

The script just ping the Atlas server endpoint without performing the login. It should work
with SSO solutions. It also assumes that the script runs on the same host as the Atlas server
and is able to access directly to the server endpoint.


> On Aug. 11, 2017, 11:11 a.m., David Radley wrote:
> > distro/src/bin/atlas_config.py
> > Lines 477 (patched)
> > <https://reviews.apache.org/r/61561/diff/1/?file=1794995#file1794995line477>
> >
> >     If we have failures during startup, how can we tell  the polling to cease?

Just like _wait_for_shutdown_, the polling has a timeout setting (5 mins). The timeout is
the only way to stop the polling. There is no callbacks from the server. Maybe we can try
to tail and grep the log file to see there is any failures during startup.


- Richard


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61561/#review182676
-----------------------------------------------------------


On Aug. 10, 2017, 5:47 p.m., Richard Ding wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61561/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2017, 5:47 p.m.)
> 
> 
> Review request for atlas, David Radley, Madhan Neethiraj, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-1218
>     https://issues.apache.org/jira/browse/ATLAS-1218
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> This patch implements a wait_for_startup function modeled after wait_for_shutdown function.
> 
> 
> Diffs
> -----
> 
>   distro/src/bin/atlas_config.py 1be9ca2b 
>   distro/src/bin/atlas_start.py a6a3455c 
> 
> 
> Diff: https://reviews.apache.org/r/61561/diff/1/
> 
> 
> Testing
> -------
> 
> Here are the output of atlas_start and atlas_stop script:
> ```
> starting atlas on port 21000
> ........................................................................................................................
> Apache Atlas Server started!!!
> ```
> and
> ```
> stopping atlas........
> Apache Atlas Server stopped!!!
> ```
> 
> 
> Thanks,
> 
> Richard Ding
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message