atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Radley <david...@apache.org>
Subject Re: Review Request 61589: [ATLAS-2040]: Relationship with many-to-many cardinality gives incorrect relationship attribute value
Date Fri, 11 Aug 2017 15:21:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61589/#review182702
-----------------------------------------------------------



- David Radley


On Aug. 11, 2017, 7:33 a.m., Sarath Subramanian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61589/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2017, 7:33 a.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-2040
>     https://issues.apache.org/jira/browse/ATLAS-2040
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Relationship with many-to-many cardinality gives incorrect relationship attribute value
when same attribute name and same type specified at both ends
> When same attribute name and same type is mentioned in both ends of relationship definition.
Creating new relationships fails to retireve the right value.
> For e.g. employee-friends type: same attribute name 'friends' in type 'Employee' specified
at both ends
> Add more unit tests to test these cases
> 
> 
> Diffs
> -----
> 
>   intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java 934dffce 
>   intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 277d0fa2 
>   intg/src/test/java/org/apache/atlas/TestRelationshipUtilsV2.java 98be2b8d 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 1ec5a72e

>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java
42713763 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java
b8fd70e5 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java
667c61bd 
>   repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreHardDeleteV1Test.java
2c311403 
>   repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreSoftDeleteV1Test.java
33ef8c0f 
>   repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1Test.java
a35647dc 
> 
> 
> Diff: https://reviews.apache.org/r/61589/diff/2/
> 
> 
> Testing
> -------
> 
> * added new  UTs to test many-to-many relationships on same attribute name/same type
> * added new  UTs to test one-to-one relationships on same attribute name/same type
> * mvn clean install -DskipITs=true suceeded without any failures
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message