atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Radley <david_rad...@uk.ibm.com>
Subject Re: Review Request 61085: ATLAS-1983: Add relationship cardinality validation
Date Wed, 09 Aug 2017 08:19:49 GMT


> On July 24, 2017, 7:15 p.m., Madhan Neethiraj wrote:
> > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1.java
> > Lines 128 (patched)
> > <https://reviews.apache.org/r/61085/diff/1/?file=1781424#file1781424line134>
> >
> >     consider using vertex.getEdges(direction, edgeLabel), instead of iterating through
edges to find the one with the expected label.

Hi Madhan, 
I can't see how to use this method as I am looking for edges with the relationship prefix
- so I am iterating and them checking for a substring of the label. This method would match
the complete label. If I have misunderstood, let me know.  
   David.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61085/#review181253
-----------------------------------------------------------


On July 24, 2017, 5:18 p.m., David Radley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61085/
> -----------------------------------------------------------
> 
> (Updated July 24, 2017, 5:18 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj and Sarath Subramanian.
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-1983: Add relationship cardinality validation
> 
> 
> Diffs
> -----
> 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java b24f99f6f9337aa10f40e9f10024fe5a345c3540

>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasRelationshipDef.java c17e875d10169753b76fcdb483e2ca85195104b2

>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1.java
49e08a070a803a36253b502666947ab92ffe39d3 
> 
> 
> Diff: https://reviews.apache.org/r/61085/diff/1/
> 
> 
> Testing
> -------
> 
> ran Junits 
> Successfully added one relationship, then added a second which resulted in the error.
> 
> 
> Thanks,
> 
> David Radley
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message