Mailing-List: contact dev-help@atlas.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@atlas.apache.org
Date: Wed, 26 Jul 2017 16:36:01 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: dev@atlas.apache.org
Message-ID: <JIRA.13080423.1497623555000.19178.1501086961329@Atlassian.JIRA>
In-Reply-To: <JIRA.13080423.1497623555000@Atlassian.JIRA>
References: <JIRA.13080423.1497623555000@Atlassian.JIRA> <JIRA.13080423.1497623555190@jira-lw-us.apache.org>
Subject: [jira] [Commented] (ATLAS-1879) Updating classification removes
 some properties
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Wed, 26 Jul 2017 16:36:07 -0000


    [ https://issues.apache.org/jira/browse/ATLAS-1879?page=3Dcom.atlassian=
.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1610=
1894#comment-16101894 ]=20

ASF GitHub Bot commented on ATLAS-1879:
---------------------------------------

Github user mneethiraj commented on a diff in the pull request:

    https://github.com/apache/incubator-atlas/pull/39#discussion_r129626331
 =20
    --- Diff: repository/src/main/java/org/apache/atlas/repository/store/gr=
aph/AtlasTypeDefGraphStore.java ---
    @@ -381,6 +381,12 @@ public AtlasTypesDef updateTypesDef(AtlasTypesDef =
typesDef) throws AtlasBaseExce
    =20
             AtlasTypesDef ret =3D updateGraphStore(typesDef, ttr);
    =20
    +        try {
    +            ttr.updateTypesWithNoRefResolve(ret);
    --- End diff --
   =20
    Call updateTypes(), instead of updateTypesWithNoRefResolve() - "*WithNo=
RefResolve()" calls will not run resolveReferences() hence will leave type =
objects with no reference to other types (for example: an entity-type will =
not have its references set for other entity-types references by it).


> Updating classification removes some properties
> -----------------------------------------------
>
>                 Key: ATLAS-1879
>                 URL: https://issues.apache.org/jira/browse/ATLAS-1879
>             Project: Atlas
>          Issue Type: Bug
>          Components:  atlas-core
>    Affects Versions: 0.8-incubating
>            Reporter: Laura Ngo
>            Assignee: P=C3=A9ter Gerg=C5=91 Barna
>         Attachments: Atlas-1789.postman_collection.json
>
>
> * Created classification via POST.=20
> * Updated via PUT
> * Lost properties
> POST http://127.0.0.1:21000/api/atlas/v2/types/typedefs
> {code}
> {
>  "classificationDefs": [{
>   "name": "test_classification_11",
>   "description": "",
>   "createdBy" : "admin",
>   "superTypes": [],
>   "attributeDefs": [{
>     "name" : "test_class_11",
>     "typeName" : "string",
>     "isOptional" : true,
>     "isUnique" : true,
>     "isIndexable" : true,
>     "cardinality": "SINGLE",
>     "valuesMinCount": 0,
>     "valuesMaxCount": 1
> }]
>  }],
>  "entityDefs": [],
>  "enumDefs": [],
>  "structDefs": []
> }
> {code}
> GET http://127.0.0.1:21000/api/atlas/v2/types/classification/name/test_cl=
assification_11
> {code}
> {
> "category": "CLASSIFICATION",
> "guid": "83162fe1-4bb4-4a87-b2b8-364e751a1265",
> "createdBy": "admin",
> "createTime": 1497485890857,
> "updateTime": 1497485890857,
> "version": 1,
> "name": "test_classification_11",
> "description": "",
> "typeVersion": "1.0",
> "attributeDefs": [
>   {
> "name": "test_class_11",
> "typeName": "string",
> "isOptional": true,
> "cardinality": "SINGLE",
> "valuesMinCount": 0,
> "valuesMaxCount": 1,
> "isUnique": true,
> "isIndexable": true
> }
> ],
> "superTypes": [],
> }
> {code}
> PUT http://127.0.0.1:21000/api/atlas/v2/types/typedefs
> Update attribute.
> GET http://127.0.0.1:21000/api/atlas/v2/types/classification/name/test_cl=
assification_11
> {code}
> {
> "category": "CLASSIFICATION",
> "createdBy": "admin",
> "name": "test_classification_11",
> "description": "",
> "attributeDefs": [
>   {
> "name": "test_class_11",
> "typeName": "string",
> "isOptional": true,
> "cardinality": "SINGLE",
> "valuesMinCount": 0,
> "valuesMaxCount": 1,
> "isUnique": true,
> "isIndexable": false
> }
> ],
> "superTypes": [],
> }
> {code}
> Some properties are missing after PUT update of attribute "isIndexable"


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)