Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 84BE4200CD5 for ; Sun, 30 Jul 2017 10:41:50 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 83501164716; Sun, 30 Jul 2017 08:41:50 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id C6433164712 for ; Sun, 30 Jul 2017 10:41:49 +0200 (CEST) Received: (qmail 84871 invoked by uid 500); 30 Jul 2017 08:41:49 -0000 Mailing-List: contact dev-help@atlas.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@atlas.apache.org Delivered-To: mailing list dev@atlas.apache.org Received: (qmail 84853 invoked by uid 99); 30 Jul 2017 08:41:48 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 30 Jul 2017 08:41:48 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 3637FC03F8; Sun, 30 Jul 2017 08:41:48 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.999 X-Spam-Level: ** X-Spam-Status: No, score=2.999 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 4IvkqNO8Tb4g; Sun, 30 Jul 2017 08:41:47 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 085B55FC1C; Sun, 30 Jul 2017 08:41:47 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 476BFE0059; Sun, 30 Jul 2017 08:41:44 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 5EE8CC400D8; Sun, 30 Jul 2017 08:41:43 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3517308749736859115==" MIME-Version: 1.0 Subject: Re: Review Request 61130: Search API folding and tag attribute honoring From: Madhan Neethiraj To: Madhan Neethiraj Cc: Apoorv Naik , atlas Date: Sun, 30 Jul 2017 08:41:43 -0000 Message-ID: <20170730084143.20472.20182@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Madhan Neethiraj X-ReviewGroup: atlas X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/61130/ X-Sender: Madhan Neethiraj X-ReviewBoard-ShipIt: 1 References: <20170730045338.63649.67442@reviews-vm2.apache.org> In-Reply-To: <20170730045338.63649.67442@reviews-vm2.apache.org> X-ReviewBoard-ShipIt-Only: 1 Reply-To: Madhan Neethiraj X-ReviewRequest-Repository: atlas archived-at: Sun, 30 Jul 2017 08:41:50 -0000 --===============3517308749736859115== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61130/#review181772 ----------------------------------------------------------- Ship it! Ship It! - Madhan Neethiraj On July 30, 2017, 4:53 a.m., Apoorv Naik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61130/ > ----------------------------------------------------------- > > (Updated July 30, 2017, 4:53 a.m.) > > > Review request for atlas and Madhan Neethiraj. > > > Bugs: ATLAS-1994 > https://issues.apache.org/jira/browse/ATLAS-1994 > > > Repository: atlas > > > Description > ------- > > Currently when the entity text query is specified with the entity and it's filters none of the tag attributes are considered during filtering (search). This change honors the tag attributes during search even under the above scenario > > TODO: Caching of the gremlin expression for tag attribute filtering, add '-' the offending char list > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 9e263d70 > repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java dcdcbbbb > repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java 385951bc > repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 7e096720 > repository/src/main/java/org/apache/atlas/util/AtlasGremlin2QueryProvider.java 1bf03464 > repository/src/main/java/org/apache/atlas/util/AtlasGremlinQueryProvider.java 8481a4f6 > webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java efab72a3 > > > Diff: https://reviews.apache.org/r/61130/diff/2/ > > > Testing > ------- > > Ongoing > > > Thanks, > > Apoorv Naik > > --===============3517308749736859115==--