Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id F0AAB200CD3 for ; Fri, 28 Jul 2017 23:44:41 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id EF2CB16D93B; Fri, 28 Jul 2017 21:44:41 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 6021C16D933 for ; Fri, 28 Jul 2017 23:44:40 +0200 (CEST) Received: (qmail 42112 invoked by uid 500); 28 Jul 2017 21:44:39 -0000 Mailing-List: contact dev-help@atlas.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@atlas.apache.org Delivered-To: mailing list dev@atlas.apache.org Received: (qmail 42101 invoked by uid 99); 28 Jul 2017 21:44:39 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 28 Jul 2017 21:44:39 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id D0C12C024C; Fri, 28 Jul 2017 21:44:38 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 4.201 X-Spam-Level: **** X-Spam-Status: No, score=4.201 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id MvbVq3BVhLiX; Fri, 28 Jul 2017 21:44:37 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 22A815FB32; Fri, 28 Jul 2017 21:44:37 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id BB768E00A3; Fri, 28 Jul 2017 21:44:36 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 4BE5CC40110; Fri, 28 Jul 2017 21:44:35 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0028554734638249480==" MIME-Version: 1.0 Subject: Review Request 61233: Default error page for Atlas web endpoints From: Apoorv Naik To: Madhan Neethiraj Cc: Apoorv Naik , atlas Date: Fri, 28 Jul 2017 21:44:34 -0000 Message-ID: <20170728214434.64277.53161@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Apoorv Naik X-ReviewGroup: atlas X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/61233/ X-Sender: Apoorv Naik X-ReviewBoard-Diff-For: webapp/src/main/webapp/error.jsp Reply-To: Apoorv Naik X-ReviewRequest-Repository: atlas archived-at: Fri, 28 Jul 2017 21:44:42 -0000 --===============0028554734638249480== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61233/ ----------------------------------------------------------- Review request for atlas and Madhan Neethiraj. Repository: atlas Description ------- Any 404, 500 or Throwable should result is display of default error page insted of exposing server details which might expose some critical internal details. Diffs ----- webapp/src/main/webapp/WEB-INF/web.xml 9b5c3b14 webapp/src/main/webapp/error.jsp PRE-CREATION Diff: https://reviews.apache.org/r/61233/diff/1/ Testing ------- Tested with UI interaction, any invalid request now lands on error.jsp Thanks, Apoorv Naik --===============0028554734638249480==--