Mailing-List: contact dev-help@atlas.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@atlas.apache.org
Content-Type: multipart/alternative;
 boundary="===============4355993537854053368=="
MIME-Version: 1.0
Subject: Re: Review Request 61002: ATLAS-1968: Import File Signature Change
From: Ashutosh Mestry <amestry@hortonworks.com>
To: Madhan Neethiraj <madhan@apache.org>
Cc: Ashutosh Mestry <amestry@hortonworks.com>,
 atlas <dev@atlas.incubator.apache.org>
Date: Thu, 20 Jul 2017 17:22:34 -0000
Message-ID: <20170720172234.21523.94368@reviews-vm2.apache.org>
Auto-Submitted: auto-generated
Sender: Ashutosh Mestry <noreply@reviews.apache.org>
References: <20170720170539.21523.44535@reviews-vm2.apache.org>
In-Reply-To: <20170720170539.21523.44535@reviews-vm2.apache.org>
Reply-To: Ashutosh Mestry <amestry@hortonworks.com>
archived-at: Thu, 20 Jul 2017 17:22:39 -0000

--===============4355993537854053368==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61002/
-----------------------------------------------------------

(Updated July 20, 2017, 5:22 p.m.)


Review request for atlas and Madhan Neethiraj.


Changes
-------

Updates include:
- Updated TWIKI documentation.


Bugs: ATLAS-1968
    https://issues.apache.org/jira/browse/ATLAS-1968


Repository: atlas


Description
-------

**Background**
The Import API that takes file as input was changed to make it consistent with the other API that takes ZIP stream as input.

This change did not correctly reflect within _ImportService_.

**Solution**
_AtlasImportRequest_ has been updated to add the _fileName_ option.

**CURL**

Note that the file path should be a path on the server.

_importOptions.json_ contents:
```javascript
{
    "options": {
        "fileName": "/root/smalldb.zip"
    }
}
```

CURL
```bash
curl -g -X POST -u admin:admin -H "Content-Type: application/json" -H "Cache-Control: no-cache" -d @./importOptions.json "http://localhost:21000/api/atlas/admin/importFile"
```


Diffs (updated)
-----

  docs/src/site/twiki/Import-API-Options.twiki 85887844 
  docs/src/site/twiki/Import-API.twiki b5de113f 
  intg/src/main/java/org/apache/atlas/model/impexp/AtlasImportRequest.java 4d2ac627 
  repository/src/main/java/org/apache/atlas/repository/impexp/ImportService.java 92217178 


Diff: https://reviews.apache.org/r/61002/diff/2/

Changes: https://reviews.apache.org/r/61002/diff/1-2/


Testing
-------

**Functional test**
Imported ZIP file using the new API.

**Unit tests**
None.


Thanks,

Ashutosh Mestry


--===============4355993537854053368==--