Mailing-List: contact dev-help@atlas.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@atlas.apache.org
Content-Type: multipart/alternative;
 boundary="===============5426972534948824925=="
MIME-Version: 1.0
Subject: Re: Review Request 60857: ATLAS-1950: Import API: Improvement: Specify
 Supertypes in Import Transforms
From: Ashutosh Mestry <amestry@hortonworks.com>
To: Madhan Neethiraj <madhan@apache.org>, Ayub Pathan <aryanayub786@gmail.com>
Cc: Ashutosh Mestry <amestry@hortonworks.com>,
 atlas <dev@atlas.incubator.apache.org>
Date: Fri, 14 Jul 2017 18:00:03 -0000
Message-ID: <20170714180003.2425.92518@reviews-vm2.apache.org>
Auto-Submitted: auto-generated
Sender: Ashutosh Mestry <noreply@reviews.apache.org>
References: <20170713233819.55863.51217@reviews-vm2.apache.org>
In-Reply-To: <20170713233819.55863.51217@reviews-vm2.apache.org>
Reply-To: Ashutosh Mestry <amestry@hortonworks.com>
archived-at: Fri, 14 Jul 2017 18:00:07 -0000

--===============5426972534948824925==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60857/
-----------------------------------------------------------

(Updated July 14, 2017, 6 p.m.)


Review request for atlas, Ayub Pathan and Madhan Neethiraj.


Changes
-------

Updates include:
- Updated request with issue id.


Summary (updated)
-----------------

ATLAS-1950: Import API: Improvement: Specify Supertypes in Import Transforms


Bugs: ATLAS-1950
    https://issues.apache.org/jira/browse/ATLAS-1950


Repository: atlas


Description
-------

**Background**
Existing import transforms expects that the user specify each type and attribute name that needs to be transformed. This may cause large number of transform enumerating individual types to be specified. Specifying individual transforms may be tedious and perhaps error prone.

**Solution**
This feature improves on that case by allowing user to specify super types. That way the sub types of that type will automatically get the transform(s) applied.

**Implementation**
User can now specify transforms like:

```javascript
{
    "options": {
        "transforms": "{ \"Asset\": { \"qualifiedName\": [ \"replace:@cl1:@cl2\" ] } }"
    }
}
```

At runtime, the subtypes of this type are enumerated. The attribute and tranform map of the super type are now associated with all the sub-types.


Diffs
-----

  repository/src/main/java/org/apache/atlas/repository/impexp/ImportService.java 92217178 
  repository/src/main/java/org/apache/atlas/repository/impexp/ImportTransforms.java 63e53c50 
  repository/src/test/java/org/apache/atlas/repository/impexp/ImportServiceTest.java de8e7ef3 


Diff: https://reviews.apache.org/r/60857/diff/1/


Testing
-------

**Unit tests**
Unit test verifying this behavior were added.

**Functional tests**
Regular imports were run.


Thanks,

Ashutosh Mestry


--===============5426972534948824925==--