Mailing-List: contact dev-help@atlas.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@atlas.apache.org
Content-Type: multipart/alternative;
 boundary="===============3847298039562510254=="
MIME-Version: 1.0
Subject: Re: Review Request 60285: [ATLAS-1892]: Implement logic to create
 relationship attributes in AtlasEntityType
From: David Radley <david_radley@uk.ibm.com>
To: Apoorv Naik <naik.apoorv@gmail.com>, Madhan Neethiraj <madhan@apache.org>,
 Ashutosh Mestry <amestry@hortonworks.com>,
 Nixon Rodrigues <nixon.rodrigues@freestoneinfotech.com>
Cc: atlas <dev@atlas.incubator.apache.org>,
 David Radley <david_radley@uk.ibm.com>, Sarath Subramanian <sarath@apache.org>
Date: Thu, 06 Jul 2017 10:55:23 -0000
Message-ID: <20170706105523.36467.46367@reviews-vm2.apache.org>
Auto-Submitted: auto-generated
Sender: David Radley <noreply@reviews.apache.org>
References: <20170622215124.61729.49454@reviews-vm2.apache.org>
In-Reply-To: <20170622215124.61729.49454@reviews-vm2.apache.org>
Reply-To: David Radley <david_radley@uk.ibm.com>
archived-at: Thu, 06 Jul 2017 10:55:30 -0000

--===============3847298039562510254==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60285/#review179764
-----------------------------------------------------------


intg/src/main/java/org/apache/atlas/AtlasErrorCode.java
Lines 96 (patched)
<https://reviews.apache.org/r/60285/#comment254598>

    updateion => update
    the error seems to be called from a validate method which is only called for create, so the error label should not be CRUD. Can this error be issues for updates ?


intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java
Lines 200 (patched)
<https://reviews.apache.org/r/60285/#comment254600>

    I had merge issues when I tried to apply this patch.  for me this resulted in 2 of these methods and a compile error. I think this method has already been committed. 
    I also got a merge conflict inthe AtlasErrorCode - on 2 comments that looked the same.


intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java
Lines 221 (patched)
<https://reviews.apache.org/r/60285/#comment254601>

    shouldn't there be an else here so we can error in the case where we have already use this attribute name .


repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1.java
Lines 261 (patched)
<https://reviews.apache.org/r/60285/#comment254599>

    the messages should have message numbers.


- David Radley


On June 22, 2017, 9:51 p.m., Sarath Subramanian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60285/
> -----------------------------------------------------------
> 
> (Updated June 22, 2017, 9:51 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, and Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-1892
>     https://issues.apache.org/jira/browse/ATLAS-1892
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> When a new relationshipDef is created, relation attributes needs to be populated in AtlasEntityType during resolveReference stage.
> This JIRA also adds UT, IT and addresses review comments in https://reviews.apache.org/r/59769/
> 
> 
> Diffs
> -----
> 
>   authorization/src/main/java/org/apache/atlas/authorize/AtlasResourceTypes.java 925b6b13 
>   authorization/src/main/java/org/apache/atlas/authorize/simple/AtlasAuthorizationUtils.java bb3157a3 
>   authorization/src/main/java/org/apache/atlas/authorize/simple/PolicyParser.java acf73882 
>   distro/src/conf/policy-store.txt 47583c1e 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java e8971a80 
>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasRelationshipEndDef.java 34e932ed 
>   intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java a29f7fb6 
>   intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java 38b68bbd 
>   intg/src/test/java/org/apache/atlas/type/TestAtlasRelationshipType.java 7a4e9fd5 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1.java 8fe48885 
>   webapp/src/main/java/org/apache/atlas/web/rest/RelationshipREST.java 144080ad 
> 
> 
> Diff: https://reviews.apache.org/r/60285/diff/3/
> 
> 
> Testing
> -------
> 
> UT added and tested.
> IT in progress.
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>


--===============3847298039562510254==--