atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Madhan Neethiraj <mad...@apache.org>
Subject Review Request 61246: ATLAS-2008: basic-search: updated Gremlin query used in tag-attribute filtering to use bind variables
Date Sun, 30 Jul 2017 18:53:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61246/
-----------------------------------------------------------

Review request for atlas.


Bugs: ATLAS-2008
    https://issues.apache.org/jira/browse/ATLAS-2008


Repository: atlas


Description
-------

Gremlin query used in tag-attribute filtering fails when the filter includes attributes of
numeric type - due to Gremlin parsing integer values to java.lang.Integer (which causes comparision
with double/dloat/.. attribute values to fail) and float/double values to java.math.BigDecimal
(which causes comparision with float/double type attributes to fail). Use of bind variables
in queries resolves this issue.

Also, renamed variable names that incorrectly referenced "gremlin" to "graph" and "solr" to
"index".


Diffs
-----

  repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java f94d24b1

  repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java 59fed173

  repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 31d145cd 


Diff: https://reviews.apache.org/r/61246/diff/1/


Testing
-------

Verified that tag-filtering executes correctly for numeric, date, string, enum type attributes.


Thanks,

Madhan Neethiraj


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message