atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Madhan Neethiraj <mad...@apache.org>
Subject Re: Review Request 61130: Search API folding and tag attribute honoring
Date Sun, 30 Jul 2017 08:41:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61130/#review181772
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On July 30, 2017, 4:53 a.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61130/
> -----------------------------------------------------------
> 
> (Updated July 30, 2017, 4:53 a.m.)
> 
> 
> Review request for atlas and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-1994
>     https://issues.apache.org/jira/browse/ATLAS-1994
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Currently when the entity text query is specified with the entity and it's filters none
of the tag attributes are considered during filtering (search). This change honors the tag
attributes during search even under the above scenario
> 
> TODO: Caching of the gremlin expression for tag attribute filtering, add '-' the offending
char list
> 
> 
> Diffs
> -----
> 
>   intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 9e263d70 
>   repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java
dcdcbbbb 
>   repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java 385951bc

>   repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 7e096720 
>   repository/src/main/java/org/apache/atlas/util/AtlasGremlin2QueryProvider.java 1bf03464

>   repository/src/main/java/org/apache/atlas/util/AtlasGremlinQueryProvider.java 8481a4f6

>   webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java efab72a3 
> 
> 
> Diff: https://reviews.apache.org/r/61130/diff/2/
> 
> 
> Testing
> -------
> 
> Ongoing
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message