atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Madhan Neethiraj <mad...@apache.org>
Subject Re: Review Request 61002: ATLAS-1968: Import File Signature Change
Date Thu, 20 Jul 2017 17:39:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61002/#review181062
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On July 20, 2017, 5:22 p.m., Ashutosh Mestry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61002/
> -----------------------------------------------------------
> 
> (Updated July 20, 2017, 5:22 p.m.)
> 
> 
> Review request for atlas and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-1968
>     https://issues.apache.org/jira/browse/ATLAS-1968
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> **Background**
> The Import API that takes file as input was changed to make it consistent with the other
API that takes ZIP stream as input.
> 
> This change did not correctly reflect within _ImportService_.
> 
> **Solution**
> _AtlasImportRequest_ has been updated to add the _fileName_ option.
> 
> **CURL**
> 
> Note that the file path should be a path on the server.
> 
> _importOptions.json_ contents:
> ```javascript
> {
>     "options": {
>         "fileName": "/root/smalldb.zip"
>     }
> }
> ```
> 
> CURL
> ```bash
> curl -g -X POST -u admin:admin -H "Content-Type: application/json" -H "Cache-Control:
no-cache" -d @./importOptions.json "http://localhost:21000/api/atlas/admin/importFile"
> ```
> 
> 
> Diffs
> -----
> 
>   docs/src/site/twiki/Import-API-Options.twiki 85887844 
>   docs/src/site/twiki/Import-API.twiki b5de113f 
>   intg/src/main/java/org/apache/atlas/model/impexp/AtlasImportRequest.java 4d2ac627 
>   repository/src/main/java/org/apache/atlas/repository/impexp/ImportService.java 92217178

> 
> 
> Diff: https://reviews.apache.org/r/61002/diff/2/
> 
> 
> Testing
> -------
> 
> **Functional test**
> Imported ZIP file using the new API.
> 
> **Unit tests**
> None.
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message