atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Madhan Neethiraj <mad...@apache.org>
Subject Re: Review Request 60980: ATLAS-1961: Basic search improvement in use of Solr index for attribute filtering (# 3)
Date Thu, 20 Jul 2017 08:31:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60980/
-----------------------------------------------------------

(Updated July 20, 2017, 8:31 a.m.)


Review request for atlas.


Changes
-------

updated to choose appropriate start-offset, to handle 'state filter' (to exclude deleted entities)


Bugs: ATLAS-1961
    https://issues.apache.org/jira/browse/ATLAS-1961


Repository: atlas


Description
-------

- fixed NPE when search includes a free-text query & a classification that has large number
of sub-types
- fixed entity search in Solr to include state filter


Diffs (updated)
-----

  repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java b6e0de5c

  repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java 6f629eb4

  repository/src/main/java/org/apache/atlas/discovery/FullTextSearchProcessor.java 22d91e04

  repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 2e75dfeb 


Diff: https://reviews.apache.org/r/60980/diff/3/

Changes: https://reviews.apache.org/r/60980/diff/2-3/


Testing
-------

- validated that the fix addressed the error cases listed above


Thanks,

Madhan Neethiraj


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message