atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Madhan Neethiraj <mad...@apache.org>
Subject Re: Review Request 60722: Fix for: Export of hive_table with fetchType "connected" fails
Date Mon, 17 Jul 2017 17:13:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60722/#review180695
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On July 10, 2017, 3:59 p.m., Ashutosh Mestry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60722/
> -----------------------------------------------------------
> 
> (Updated July 10, 2017, 3:59 p.m.)
> 
> 
> Review request for atlas and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-1919
>     https://issues.apache.org/jira/browse/ATLAS-1919
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> **Analysis**
> The connected _fetchType_ in Export API had a potential for attempting to save same entity
twice.
> 
> **Fix**
> The entities saved to the _ZipSink_ are now maintained in a separate set. Before attempting
to save to _ZipSink_ existence check is performed. If passed, save is prevented, else entity
is saved to _ZipSink_.
> 
> 
> Diffs
> -----
> 
>   repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java 3538cfd7

>   repository/src/main/java/org/apache/atlas/repository/impexp/ZipSink.java 4bb04da9 
>   repository/src/test/java/org/apache/atlas/repository/impexp/ZipSinkTest.java 635caf7f

> 
> 
> Diff: https://reviews.apache.org/r/60722/diff/2/
> 
> 
> Testing
> -------
> 
> **Unit tests**
> - Executed existing unit tests.
> 
> **Functional tests**
> - Executed standard set of tests.
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message