atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Madhan Neethiraj <mad...@apache.org>
Subject Re: Review Request 60742: ATLAS-1938 : UI - Search using entity and trait attributes - Refresh Button fires the search query (Basic/DSL) again.
Date Mon, 10 Jul 2017 13:53:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60742/#review180030
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On July 10, 2017, 11:59 a.m., Kalyani Kashikar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60742/
> -----------------------------------------------------------
> 
> (Updated July 10, 2017, 11:59 a.m.)
> 
> 
> Review request for atlas, keval bhatt, Madhan Neethiraj, and Nixon Rodrigues.
> 
> 
> Bugs: ATLAS-1938
>     https://issues.apache.org/jira/browse/ATLAS-1938
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> On clicking of Refresh Button, makes the following 2 queries :
>  1./api/atlas/v2/types/typedefs/headers
>  2.Search query
> Before the new search feature in place, only query no.1 was made.
> In Advanced search tab , when refresh button is clicked without any type or query , following
invalid query is made in addition to query no.1
> http://localhost:21000/api/atlas/v2/search?
> which throws 500 Internal server error.
> 
> 
> Diffs
> -----
> 
>   dashboardv2/public/js/views/search/SearchLayoutView.js 7ac394c 
> 
> 
> Diff: https://reviews.apache.org/r/60742/diff/1/
> 
> 
> Testing
> -------
> 
> Verified when browser URL contains type/tag/query in basic or advance search.
>  1./api/atlas/v2/types/typedefs/headers
>  2.Search query 
> Otherwise on click of refresh button only one api is called i.e /api/atlas/v2/types/typedefs/headers.
> 
> 
> Thanks,
> 
> Kalyani Kashikar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message