atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Apoorv Naik <naik.apo...@gmail.com>
Subject Re: Review Request 60627: ATLAS-1906 :- Atlas client should support setting hadoop-jwt token in header
Date Wed, 05 Jul 2017 17:45:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60627/#review179662
-----------------------------------------------------------




client/src/main/java/org/apache/atlas/AtlasBaseClient.java
Lines 111 (patched)
<https://reviews.apache.org/r/60627/#comment254471>

    Should we make this more generic so that a non-hadoop ecosytem can also benefit for such
a use case ?



common/src/main/java/org/apache/atlas/utils/AuthenticationUtil.java
Lines 46 (patched)
<https://reviews.apache.org/r/60627/#comment254476>

    Does it make sense to add a check in the callAPI to maybe log a warning if knox is enabled
and no cookie is set ?
    
    Also where is **isKnoxSsoEnabled** used ?


- Apoorv Naik


On July 5, 2017, 2:37 p.m., Nixon Rodrigues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60627/
> -----------------------------------------------------------
> 
> (Updated July 5, 2017, 2:37 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, Sarath Subramanian,
and Hemanth Yamijala.
> 
> 
> Bugs: ATLAS-1906
>     https://issues.apache.org/jira/browse/ATLAS-1906
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> This patch adds support to AtlasClient(Rest) to add Knox SSO Cookie as authentication
header for Atlas.
> 
> Currently Atlas Client supports UGI & Basic Auth, as part of this jira i will overload
the Atlas Client constructor to support Knox SSO cookie by adding below constructor.
> 
> AtlasClient(atlasURL, cookieName, CookieValue, path, domain);
> AtlasClient(atlasURL, Cookie);
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/atlas/AtlasAdminClient.java b61b2bf 
>   client/src/main/java/org/apache/atlas/AtlasBaseClient.java 98da51e 
>   client/src/main/java/org/apache/atlas/AtlasClient.java ec482da 
>   client/src/main/java/org/apache/atlas/AtlasClientV2.java 7e287e7 
>   common/src/main/java/org/apache/atlas/utils/AuthenticationUtil.java 09d8085 
> 
> 
> Diff: https://reviews.apache.org/r/60627/diff/3/
> 
> 
> Testing
> -------
> 
> Unit test cases are running fine using mvn clean install.
> Ran Quick Start and Atlas admin script using the new Atlasclient Constructor.
> 
> AltasClient(atlasUrl, new Cookie("hadoop-jwt" , "eyJhbGciOiJSUzI1NiJ9.eyJzdWIiOiJhZG1pbiIsImlzcyI6IktOT1hTU08iLCJleHAiOjE1MDE5NzUzNTV9.K7lTaXniXJtrdkXAG_k7MwhWpL363NPC75fA4hvY7ilNXCOr-_gVV-ZLndVxMGFmbSl-cLHv3ormDH2W2hvUQhUDvXg3QN5iQGlEoVDPjO6O1yoNnMBW0VgVhAbSimRQ5NTMgAF09gkTsPIfG8Qhu2kcvkKEMFOfcsDyrKn2cRM");
> 
> 
> Thanks,
> 
> Nixon Rodrigues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message