atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ramesh Mani <rm...@hortonworks.com>
Subject Re: Review Request 59821: ATLAS-1805:Provide an Atlas hook to send Hbase Namespace/Table/column family metadata to Atlas
Date Fri, 23 Jun 2017 00:22:48 GMT


> On June 6, 2017, 4:39 a.m., Madhan Neethiraj wrote:
> > addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/hook/HBaseAtlasCoprocessor.java
> > Lines 273 (patched)
> > <https://reviews.apache.org/r/59821/diff/1/?file=1742021#file1742021line273>
> >
> >     Can this call be avoided from here? Instead can this be handled by the code
that sends notifications from hbaseEvent?

Madhan, HbaseEvent only holds the event context, after the refactoring of moving Send notifications
to HBaseAtlasHook, it is this handled with in HBaseAtlasHook.


> On June 6, 2017, 4:39 a.m., Madhan Neethiraj wrote:
> > addons/models/0060-hbase_model.json
> > Line 85 (original), 166 (patched)
> > <https://reviews.apache.org/r/59821/diff/1/?file=1742026#file1742026line166>
> >
> >     Why should hbase_column.column_family be an optional attribute?

hbase_column is not sent in the message now to Atlas, so If I make it madantory it requires
this to be build and sent.


- Ramesh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59821/#review176972
-----------------------------------------------------------


On June 23, 2017, 12:22 a.m., Ramesh Mani wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59821/
> -----------------------------------------------------------
> 
> (Updated June 23, 2017, 12:22 a.m.)
> 
> 
> Review request for atlas and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-1805
>     https://issues.apache.org/jira/browse/ATLAS-1805
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-1805: Provide an Atlas hook to send Hbase Namespace/Table/column family metadata
to Atlas
> 
> 
> Diffs
> -----
> 
>   addons/hbase-bridge-shim/pom.xml PRE-CREATION 
>   addons/hbase-bridge-shim/src/main/java/org/apache/atlas/hbase/hook/HBaseAtlasCoprocessor.java
PRE-CREATION 
>   addons/hbase-bridge/pom.xml PRE-CREATION 
>   addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java
PRE-CREATION 
>   addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/event/HBaseEvent.java PRE-CREATION

>   addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/hook/HBaseAtlasCoprocessor.java
PRE-CREATION 
>   addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/hook/HBaseAtlasCoprocessorBase.java
PRE-CREATION 
>   addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/model/HBaseContext.java PRE-CREATION

>   addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/model/HBaseDataTypes.java
PRE-CREATION 
>   addons/hbase-bridge/src/main/resources/atlas-hbase-import-log4j.xml PRE-CREATION 
>   addons/hbase-bridge/src/test/java/org/apache/atlas/hbase/HBaseAtlasHookTest.java PRE-CREATION

>   addons/models/0060-hbase_model.json 42fe00c 
>   distro/src/main/assemblies/standalone-package.xml 215cb23 
>   pom.xml ebc07e2 
> 
> 
> Diff: https://reviews.apache.org/r/59821/diff/2/
> 
> 
> Testing
> -------
> 
> * Review comments fixed with 2 exceptions whcih I have commented on 
> * Added an IT test
> * Testing done in LOCAL VM
> 
> 
> Thanks,
> 
> Ramesh Mani
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message