atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sarath Subramanian <sar...@apache.org>
Subject Re: Review Request 60285: [ATLAS-1892]: Implement logic to create relationship attributes in AtlasEntityType
Date Thu, 22 Jun 2017 21:51:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60285/
-----------------------------------------------------------

(Updated June 22, 2017, 2:51 p.m.)


Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues,
and Suma Shivaprasad.


Changes
-------

addressed review comments. Moved logic to add relationship attributes to resolveReferencesPhase2()


Bugs: ATLAS-1892
    https://issues.apache.org/jira/browse/ATLAS-1892


Repository: atlas


Description
-------

When a new relationshipDef is created, relation attributes needs to be populated in AtlasEntityType
during resolveReference stage.
This JIRA also adds UT, IT and addresses review comments in https://reviews.apache.org/r/59769/


Diffs (updated)
-----

  authorization/src/main/java/org/apache/atlas/authorize/AtlasResourceTypes.java 925b6b13

  authorization/src/main/java/org/apache/atlas/authorize/simple/AtlasAuthorizationUtils.java
bb3157a3 
  authorization/src/main/java/org/apache/atlas/authorize/simple/PolicyParser.java acf73882

  distro/src/conf/policy-store.txt 47583c1e 
  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java e8971a80 
  intg/src/main/java/org/apache/atlas/model/typedef/AtlasRelationshipEndDef.java 34e932ed

  intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java a29f7fb6 
  intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java 38b68bbd 
  intg/src/test/java/org/apache/atlas/type/TestAtlasRelationshipType.java 7a4e9fd5 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1.java
8fe48885 
  webapp/src/main/java/org/apache/atlas/web/rest/RelationshipREST.java 144080ad 


Diff: https://reviews.apache.org/r/60285/diff/3/

Changes: https://reviews.apache.org/r/60285/diff/2-3/


Testing
-------

UT added and tested.
IT in progress.


Thanks,

Sarath Subramanian


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message