atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Madhan Neethiraj <mad...@apache.org>
Subject Re: Review Request 59769: [ATLAS-1856]: Relationship instance API Java & REST implementation
Date Sun, 18 Jun 2017 08:51:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59769/#review178156
-----------------------------------------------------------




repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1.java
Lines 69 (patched)
<https://reviews.apache.org/r/59769/#comment252006>

    relationship.getTypeName() ==> relationship.getRelationshipLabel()



repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1.java
Lines 88 (patched)
<https://reviews.apache.org/r/59769/#comment252007>

    else {
      // throw relationship already exits exception
    }


- Madhan Neethiraj


On June 16, 2017, 10:40 p.m., Sarath Subramanian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59769/
> -----------------------------------------------------------
> 
> (Updated June 16, 2017, 10:40 p.m.)
> 
> 
> Review request for atlas and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-1856
>     https://issues.apache.org/jira/browse/ATLAS-1856
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Based on the relationDef implementation in ATLAS-1852. Implement instance API and REST
for entity relationships. This patch is not complete.
> work in progress
> 
> 
> Diffs
> -----
> 
>   authorization/src/main/java/org/apache/atlas/authorize/AtlasResourceTypes.java deccf843

>   authorization/src/main/java/org/apache/atlas/authorize/simple/AtlasAuthorizationUtils.java
e907bf5e 
>   authorization/src/main/java/org/apache/atlas/authorize/simple/PolicyParser.java 7ef49e66

>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 6c33f402 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasRelationship.java PRE-CREATION

>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasRelationshipEndDef.java 000d747b

>   intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java aebd4d1a 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasRelationshipStore.java
PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java
560b3385 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1.java
PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/typestore/GraphBackedTypeStore.java
7a064b60 
>   repository/src/test/java/org/apache/atlas/TestModules.java 095af417 
>   webapp/src/main/java/org/apache/atlas/web/rest/RelationshipREST.java PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/59769/diff/3/
> 
> 
> Testing
> -------
> 
> Tested using POSTMAN. UTs and ITs in progress.
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message