atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Madhan Neethiraj <mad...@apache.org>
Subject Re: Review Request 59881: ATLAS-1863 :- Set default value for primitive types attributes in entity based on attributeDef in Typedef
Date Fri, 16 Jun 2017 15:13:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59881/#review178109
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On June 16, 2017, 5:34 a.m., Ruchi Solani wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59881/
> -----------------------------------------------------------
> 
> (Updated June 16, 2017, 5:34 a.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Madhan Neethiraj, Nixon Rodrigues, and Sarath
Subramanian.
> 
> 
> Bugs: ATLAS-1863
>     https://issues.apache.org/jira/browse/ATLAS-1863
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> While creating entity if attribute value are not set explicitly for primitive type which
are optional, then default value should be set from attributedef.
> 
> 
> Diffs
> -----
> 
>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java aee4907 
>   intg/src/main/java/org/apache/atlas/type/AtlasArrayType.java 2d386f1 
>   intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 6516d48 
>   intg/src/main/java/org/apache/atlas/type/AtlasMapType.java 385a9ae 
>   intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 0eeaf9c 
>   intg/src/main/java/org/apache/atlas/type/AtlasType.java 28d0a07 
>   intg/src/test/java/org/apache/atlas/TestUtilsV2.java 2a6ea92 
>   intg/src/test/java/org/apache/atlas/type/TestAtlasArrayType.java e882473 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java
1c6cfc7 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java
80cd1ee 
>   repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java
44067b9 
> 
> 
> Diff: https://reviews.apache.org/r/59881/diff/3/
> 
> 
> Testing
> -------
> 
> 1. created Type using API with defaultValue attribute, and tested its entity creation
with default value being set in entity attribute.
> 2. Tested on different primitive types attributes.
> 3. Ran Unit tests using mvn clean install
>  Two unit test failing:
>    HardDeleteHandlerV1Test>AtlasDeleteHandlerV1Test.testDisconnectUnidirectionalArrayReferenceFromStructAndTraitTypes:617
» AtlasBase
>   SoftDeleteHandlerV1Test>AtlasDeleteHandlerV1Test.testDisconnectUnidirectionalArrayReferenceFromStructAndTraitTypes:617
» AtlasBase
> 
> 
> Thanks,
> 
> Ruchi Solani
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message