atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Radley <david_rad...@uk.ibm.com>
Subject Re: Review Request 60059: rename endpoints
Date Thu, 15 Jun 2017 01:22:52 GMT


> On June 14, 2017, 6:50 p.m., Apoorv Naik wrote:
> > intg/src/test/java/org/apache/atlas/model/typedef/TestAtlasRelationshipDef.java
> > Line 33 (original), 33 (patched)
> > <https://reviews.apache.org/r/60059/diff/1/?file=1751300#file1751300line33>
> >
> >     Rename this to AtlasRelationshipDefTest

All of the other files in this package have this naming convention; are we saying these are
also all incorrect?


> On June 14, 2017, 6:50 p.m., Apoorv Naik wrote:
> > intg/src/test/java/org/apache/atlas/type/TestAtlasRelationshipType.java
> > Line 27 (original), 27 (patched)
> > <https://reviews.apache.org/r/60059/diff/1/?file=1751301#file1751301line27>
> >
> >     Can you change this to org.testng.fail ? We've seen some issues with using JUnit
asserts with maven surefire plugin.

I think you mean org.testng.Assert.fail;I have made this change in line with other tests.


> On June 14, 2017, 6:50 p.m., Apoorv Naik wrote:
> > intg/src/test/java/org/apache/atlas/type/TestAtlasRelationshipType.java
> > Line 28 (original), 28 (patched)
> > <https://reviews.apache.org/r/60059/diff/1/?file=1751301#file1751301line28>
> >
> >     Also rename the class to AtlasRelationshipTypeTest as the test runner only runs
tests in the form *Test or *IT

as above


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60059/#review177934
-----------------------------------------------------------


On June 14, 2017, 5:44 p.m., David Radley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60059/
> -----------------------------------------------------------
> 
> (Updated June 14, 2017, 5:44 p.m.)
> 
> 
> Review request for atlas and Madhan Neethiraj.
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> rename endpoints. Also fixed up some comments and error messages
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/atlas/repository/Constants.java b07934b4bef7a5ccc1fbc07fa3d496fbf99690fa

>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java ca2f3d099ff69e6d7d04745c437e27501676076d

>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasRelationshipDef.java eb8330e4cda5a31457eaa5dd3ec35ba2c50beeb7

>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasRelationshipEndPointDef.java
dde8416336943e9adb16b90601f6b1d84c594404 
>   intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java 6328108ad76b459ec3b6a9deab5fa39cc6d965e8

>   intg/src/test/java/org/apache/atlas/model/typedef/TestAtlasRelationshipDef.java 78efa6e198d1b3e1edfdb7c37c249ea0444d2016

>   intg/src/test/java/org/apache/atlas/type/TestAtlasRelationshipType.java 6af374a79068ce7855d863f58a3c03fb6eadc1f0

>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipDefStoreV1.java
96cd8d13758d2de3ef1ac10cdb02b6fe55ab8813 
>   webapp/src/main/java/org/apache/atlas/examples/CreateTypesFromJsonFileUtil.java 82d6f2e3ee3f6376b7830e11900fda4e7275375b

>   webapp/src/main/java/org/apache/atlas/examples/UpdateTypesFromJsonFileUtil.java 3b6770658298849cb70e69c373f97fb4d13d1148

>   webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 0f6eeb11d90f6495498e87d31b4ff5bb4cfea1e8

> 
> 
> Diff: https://reviews.apache.org/r/60059/diff/1/
> 
> 
> Testing
> -------
> 
> junits
> create a relationshipDef
> get relationshipDef by name and guid
> get typeDefs and get typeDefs/headers
> 
> 
> Thanks,
> 
> David Radley
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message