atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kalyani Kashikar <kalyani.kashi...@freestoneinfotech.com>
Subject Re: Review Request 59876: ATLAS-1832 - If no attribute is present in tag then showing edit-button for a tag in tags tab on entity page.
Date Tue, 13 Jun 2017 06:59:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59876/
-----------------------------------------------------------

(Updated June 13, 2017, 6:59 a.m.)


Review request for atlas, keval bhatt, Madhan Neethiraj, and Nixon Rodrigues.


Changes
-------

Rebase patch for minor change in font size for audit modal.


Bugs: ATLAS-1832
    https://issues.apache.org/jira/browse/ATLAS-1832


Repository: atlas


Description
-------

Step to reproduce : - 

Create tag without attribute.
Tag detail page shows the edit button whether attribute is present or not.


Diffs (updated)
-----

  dashboardv2/public/js/templates/audit/CreateAuditTableLayoutView_tmpl.html fc8e6cc 
  dashboardv2/public/js/views/tag/TagDetailTableLayoutView.js cdbd00f 


Diff: https://reviews.apache.org/r/59876/diff/2/

Changes: https://reviews.apache.org/r/59876/diff/1-2/


Testing
-------

If no attribute is present in tag then detail page does not show edit button.
It only visiable when attribute is present in tag.


Thanks,

Kalyani Kashikar


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message