atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ruchi Solani <ruchi.sol...@freestoneinfotech.com>
Subject Re: Review Request 59881: ATLAS-1863 :- Set default value for primitive types attributes in entity based on attributeDef in Typedef
Date Mon, 12 Jun 2017 14:14:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59881/
-----------------------------------------------------------

(Updated June 12, 2017, 2:14 p.m.)


Review request for atlas, Apoorv Naik, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.


Changes
-------

This patch includes changes to address review comments given by Madhan Neethiraj


Bugs: ATLAS-1863
    https://issues.apache.org/jira/browse/ATLAS-1863


Repository: atlas


Description
-------

While creating entity if attribute value are not set explicitly for primitive type which are
optional, then default value should be set from attributedef.


Diffs (updated)
-----

  intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java aee4907 
  intg/src/main/java/org/apache/atlas/type/AtlasArrayType.java 2d386f1 
  intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 6516d48 
  intg/src/main/java/org/apache/atlas/type/AtlasEnumType.java 1cd27b3 
  intg/src/main/java/org/apache/atlas/type/AtlasMapType.java 385a9ae 
  intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 0eeaf9c 
  intg/src/main/java/org/apache/atlas/type/AtlasType.java 28d0a07 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java
1c6cfc7 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java
80cd1ee 


Diff: https://reviews.apache.org/r/59881/diff/2/

Changes: https://reviews.apache.org/r/59881/diff/1-2/


Testing
-------

1. created Type using API with defaultValue attribute, and tested its entity creation with
default value being set in entity attribute.
2. Tested on different primitive types attributes.
3. Ran Unit tests using mvn clean install
 Two unit test failing:
   HardDeleteHandlerV1Test>AtlasDeleteHandlerV1Test.testDisconnectUnidirectionalArrayReferenceFromStructAndTraitTypes:617
» AtlasBase
  SoftDeleteHandlerV1Test>AtlasDeleteHandlerV1Test.testDisconnectUnidirectionalArrayReferenceFromStructAndTraitTypes:617
» AtlasBase


Thanks,

Ruchi Solani


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message