atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ruchi Solani <ruchi.sol...@freestoneinfotech.com>
Subject Review Request 59881: ATLAS-1863 :- Set default value for primitive types attributes in entity based on attributeDef in Typedef
Date Wed, 07 Jun 2017 14:25:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59881/
-----------------------------------------------------------

Review request for atlas, Apoorv Naik, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.


Bugs: ATLAS-1863
    https://issues.apache.org/jira/browse/ATLAS-1863


Repository: atlas


Description
-------

While creating entity if attribute value are not set explicitly for primitive type which are
optional, then default value should be set from attributedef.


Diffs
-----

  intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java aee4907 
  intg/src/main/java/org/apache/atlas/type/AtlasArrayType.java 2d386f1 
  intg/src/main/java/org/apache/atlas/type/AtlasBuiltInTypes.java f08a601 
  intg/src/main/java/org/apache/atlas/type/AtlasEnumType.java 1cd27b3 
  intg/src/main/java/org/apache/atlas/type/AtlasMapType.java 385a9ae 
  intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 0eeaf9c 
  intg/src/main/java/org/apache/atlas/type/AtlasType.java 28d0a07 
  intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java c0135f5 
  intg/src/test/java/org/apache/atlas/TestUtilsV2.java 2a6ea92 
  intg/src/test/java/org/apache/atlas/model/ModelTestUtil.java 084bcc4 
  intg/src/test/java/org/apache/atlas/model/typedef/TestAtlasStructDef.java 8d2bfe2 
  intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 3c53c02 
  intg/src/test/java/org/apache/atlas/type/TestAtlasStructType.java a37dd46 
  intg/src/test/java/org/apache/atlas/type/TestAtlasTypeRegistry.java accba77 
  repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java
17b7e17 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java
1c6cfc7 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java
80cd1ee 
  repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryTest.java
8120aaa 
  repository/src/test/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStoreTest.java
9f7214c 
  repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasDeleteHandlerV1Test.java
9331e35 
  repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java
44067b9 
  webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java b59d3ee 
  webapp/src/test/java/org/apache/atlas/web/integration/TypedefsJerseyResourceIT.java c46689c



Diff: https://reviews.apache.org/r/59881/diff/1/


Testing
-------

1. created Type using API with defaultValue attribute, and tested its entity creation with
default value being set in entity attribute.
2. Tested on different primitive types attributes.
3. Ran Unit tests using mvn clean install
 Two unit test failing:
   HardDeleteHandlerV1Test>AtlasDeleteHandlerV1Test.testDisconnectUnidirectionalArrayReferenceFromStructAndTraitTypes:617
» AtlasBase
  SoftDeleteHandlerV1Test>AtlasDeleteHandlerV1Test.testDisconnectUnidirectionalArrayReferenceFromStructAndTraitTypes:617
» AtlasBase


Thanks,

Ruchi Solani


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message