Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 6CC162009DC for ; Tue, 2 May 2017 19:43:08 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 6B510160BAC; Tue, 2 May 2017 17:43:08 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B29E3160B9D for ; Tue, 2 May 2017 19:43:07 +0200 (CEST) Received: (qmail 61607 invoked by uid 500); 2 May 2017 17:43:06 -0000 Mailing-List: contact dev-help@atlas.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@atlas.incubator.apache.org Delivered-To: mailing list dev@atlas.incubator.apache.org Received: (qmail 61596 invoked by uid 99); 2 May 2017 17:43:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 May 2017 17:43:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 832A8192B89 for ; Tue, 2 May 2017 17:43:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.201 X-Spam-Level: X-Spam-Status: No, score=-99.201 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 5TL0C1AlLpM9 for ; Tue, 2 May 2017 17:43:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 1E8EA5F5C4 for ; Tue, 2 May 2017 17:43:05 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6CC9AE05BF for ; Tue, 2 May 2017 17:43:04 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2385021B53 for ; Tue, 2 May 2017 17:43:04 +0000 (UTC) Date: Tue, 2 May 2017 17:43:04 +0000 (UTC) From: "Christopher Grote (JIRA)" To: dev@atlas.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ATLAS-1740) Amend types to be more intuitive when creating multiple cardinality attributes MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 02 May 2017 17:43:08 -0000 [ https://issues.apache.org/jira/browse/ATLAS-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15993374#comment-15993374 ] Christopher Grote commented on ATLAS-1740: ------------------------------------------ I agree with [~davidrad] -- this is confusing. As another alternative to consider (though with much broader ramifications), could it be worthwhile to adopt something like JSON Schema (http://json-schema.org), or some similar definition language? This might give broader consistency and recognition in terms of how the different characteristics are defined and understood. In this example, we'd have: {code:javascript} { "type": "array", "items": { "$ref": "#/definitions/hive_column" } } {code} > Amend types to be more intuitive when creating multiple cardinality attributes > ------------------------------------------------------------------------------- > > Key: ATLAS-1740 > URL: https://issues.apache.org/jira/browse/ATLAS-1740 > Project: Atlas > Issue Type: Bug > Reporter: David Radley > > When specifying a multiple carnality attribute - for example hive-columns , Atlas has > "typeName": "array", > "cardinality": "SINGLE", > This is confusing - I read this as a single array. > I would expect MULTIPLE cardinality to be used. A more intuitive way would be to use: > "typeName": "hive_column", > "cardinality": "MULTIPLE", > How we migrate the existing API should be considered here. > I suggest clear design around when to use arrays and cardinality and what the difference - if any - is. > > -- This message was sent by Atlassian JIRA (v6.3.15#6346)