Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B020B200C6C for ; Fri, 5 May 2017 18:06:44 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id A9174160BAF; Fri, 5 May 2017 16:06:44 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 03E89160B97 for ; Fri, 5 May 2017 18:06:42 +0200 (CEST) Received: (qmail 21010 invoked by uid 500); 5 May 2017 16:06:42 -0000 Mailing-List: contact dev-help@atlas.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@atlas.incubator.apache.org Delivered-To: mailing list dev@atlas.incubator.apache.org Received: (qmail 20999 invoked by uid 99); 5 May 2017 16:06:41 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 May 2017 16:06:41 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 6A4BDCA831; Fri, 5 May 2017 16:06:41 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3 X-Spam-Level: *** X-Spam-Status: No, score=3 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id XHvcHvJqs5k0; Fri, 5 May 2017 16:06:37 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 261075F566; Fri, 5 May 2017 16:06:36 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7CDAFE05BF; Fri, 5 May 2017 16:06:35 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 4A991C402E3; Fri, 5 May 2017 16:06:35 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5967993616492698290==" MIME-Version: 1.0 Subject: Re: Review Request 58803: ATLAS-1390: IBM graph implementation From: Graham Wallis To: Neeru Gupta , Jeff Hagelberg , Graham Wallis , David Radley , David Kantor Cc: Apoorv Naik , atlas Date: Fri, 05 May 2017 16:06:35 -0000 Message-ID: <20170505160635.44875.37381@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Graham Wallis X-ReviewGroup: atlas X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/58803/ X-Sender: Graham Wallis References: <20170504163529.33378.5481@reviews-vm2.apache.org> In-Reply-To: <20170504163529.33378.5481@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/tx/IBMGraphTransaction.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/util/Batcher.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/tx/ElementBackedPropertyMap.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/IBMGraphMetadata.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/tx/DefaultUpdatedVertex.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/ElementDeletedCheckingInvocationHandler.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/json/JsonErrorResponse.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/step/ToListStep.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/GraphReadLockInvocationHandler.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/test/java/org/apache/atlas/ibmgraph/GraphDatabaseQueryTest.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/test/resources/update-logging-on-log4j.xml X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/json/PropertyKey.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/action/IPropertyValue.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/PartitionPerTenantStrategy.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/test/java/org/apache/atlas/ibmgraph/QueryBindingTest.java X-ReviewBoard-Diff-For: repository/src/test/java/org/apache/atlas/TestMetadataModule.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/stmt/ImportStatement.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/expr/GetVertexDataExpression.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/test/resources/credentials.json X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/http/HttpCode.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/IBMGraphVertexQuery.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/expr/TransformQueryResultExpression.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/util/PersistentType.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/json/JsonGraphInfo.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/AtlasPropertyKeyToPropertyKey.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/http/HttpRetryStrategy.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/mt/ITenantRegistrationListener.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/IBMGraphGraphQuery.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/http/RequestType.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/http/HttpResponse.java X-ReviewBoard-Diff-For: common/src/main/java/org/apache/atlas/GraphInitializationException.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/test/java/org/apache/atlas/ibmgraph/util/SchemaSplitterTest.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/exception/InternalServerException.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/pom.xml X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/tx/UpdatedVertex.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/util/PropertyValueToVerticesMap.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/http/HttpRequestHandler.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/json/JsonGremlinQuery.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/step/AbstractHasStep.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/util/PossibleSuccessCase.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/test/java/org/apache/atlas/ibmgraph/PropertyDuplicationTest.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/expr/GraphTraversalExpression.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/json/JsonIndexQueryResult.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/tx/DefaultUpdatedGraphElement.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/json/update/ElementIdListInfo.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/action/AbstractGraphAction.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/action/GetVertexDataAction.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/json/PropertyDataType.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/expr/EvaluableGremlinExpression.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/util/Endpoint.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/stmt/TryCatchStatement.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/graphson/AtlasGraphSONUtility.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/action/IGraphAction.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/json/update/UpdateScriptBinding.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/stmt/FetchTraversalStatement.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/test/resources/atlas-application.properties X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/util/AllowedWhenDeleted.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/json/PropertyValue.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/readme.txt X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/IBMGraphPropertyKey.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/exception/HttpException.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/json/JsonGraphElement.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/json/update/ElementType.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/expr/InstanceOfExpression.java X-ReviewBoard-Diff-For: typesystem/src/test/resources/credentials.json X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/exception/NotFoundException.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/http/IHttpRetryStrategy.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/test/java/org/apache/atlas/ibmgraph/GraphTransactionTest.java X-ReviewBoard-Diff-For: repository/src/test/java/org/apache/atlas/repository/graph/MockIntSequence.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/MultiTenancyDisabledStrategy.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/test/resources/atlas-log4j.xml X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/graphson/AtlasGraphSONTokens.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/action/ClearGraphAction.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/tx/UpdatedGraphElement.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/QueryElement.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/IBMGraphIndexQueryResult.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/tx/ReadableUpdatedGraphElement.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/util/GraphDBUtil.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/Cardinality.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/test/java/org/apache/atlas/ibmgraph/tx/TransactionMultiUserTest.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/IBMGraphElement.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/http/HttpRequest.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/IBMGraphVertex.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/stmt/PreGeneratedStatement.java X-ReviewBoard-Diff-For: repository/src/test/java/org/apache/atlas/repository/graph/TestIntSequence.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/GraphDatabaseConfiguration.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/exception/GraphDatabaseException.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/step/GraphStep.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/http/HttpUtils.java X-ReviewBoard-Diff-For: distro/src/conf/credentials.json X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/json/update/NewEdge.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/step/OrStep.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/stmt/IfStatement.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/json/IndexProperty.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/graphson/AtlasElementPropertyConfig.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/test/java/org/apache/atlas/ibmgraph/UpdateScriptLoggingOnTest.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/json/update/ElementProperty.java X-ReviewBoard-Diff-For: repository/src/test/resources/credentials.json X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/action/ElementIdPropertyValue.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/graphson/AtlasGraphSONMode.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/IndexStatus.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/json/JsonResponse.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/expr/IndexQueryExpression.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/expr/CollectExpression.java X-ReviewBoard-Diff-For: graphdb/src/test/java/org/apache/atlas/graph/GraphSandbox.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/expr/CreatePartitionExpression.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/test/java/org/apache/atlas/ibmgraph/SessionCreateTest.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/tx/ReadableUpdatedEdge.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/test/resources/update-logging-off-log4j.xml X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/test/java/org/apache/atlas/ibmgraph/AbstractGraphDatabaseTest.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/GraphPerTenantStrategy.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/readme-multitenancy-support.txt X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/json/update/ElementChanges.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/step/VertexStep.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/tx/ReadableUpdatedVertex.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/json/JsonVertexData.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/expr/TraversalSourceExpression.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/ActionTranslationContext.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/IGraphDatabaseClient.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/util/PropertyIndex.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/util/SchemaSplitter.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/action/ElementIdListPropertyValue.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/expr/InterpolatedStringExpression.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/http/HttpRequestDispatcher.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/tx/DefaultUpdatedEdge.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/json/Schema.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/QueryGenerationResult.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/json/JsonEdge.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/http/IBMGraphRequestContext.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/IBMGraphIndexQuery.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/util/UpdateSchemaRetryStrategy.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/json/JsonVertex.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/step/GremlinEvaluationResult.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/test/resources/log4j.xml X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/GraphDatabaseClient.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/test/java/org/apache/atlas/ibmgraph/UpdateScriptLoggingOffTest.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/IBMGraphIndex.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/http/IdleConnectionMonitorThread.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/GremlinQuery.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/tx/GraphTransaction.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/json/Index.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/mt/MultiTenancyConstants.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/tx/UpdatedEdge.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/step/WithinStep.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/test/java/org/apache/atlas/ibmgraph/util/BatcherTest.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/test/java/org/apache/atlas/ibmgraph/tx/ElementBackedPropertyMapTest.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/IBMGraphDatabase.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/IBMGraphGraph.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/test/java/org/apache/atlas/ibmgraph/GraphDatabaseTest.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/step/GremlinStep.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/test/java/org/apache/atlas/ibmgraph/GraphQueryTest.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/http/IHttpRequestDispatcher.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/expr/GetElementExpression.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/IBMGraphManagement.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/test/java/org/apache/atlas/ibmgraph/VertexQueryTest.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/stmt/ForLoopStatement.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/TenantGraphStrategy.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/expr/DefaultGraphTraversalExpression.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/json/JsonNewVertex.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/resources/graphUpdater.groovy X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/IBMGraphEdge.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/test/java/org/apache/atlas/ibmgraph/util/PropertyValueToVerticesMapTest.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/step/HasStep.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/util/FileUtils.java X-ReviewBoard-Diff-For: graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/exception/BadRequestException.java Reply-To: Graham Wallis X-ReviewRequest-Repository: atlas archived-at: Fri, 05 May 2017 16:06:44 -0000 --===============5967993616492698290== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58803/#review174038 ----------------------------------------------------------- Hi Apoorv, Thanks for rebasing - it's definitely better than before, but I still get a compile error when I try to build using the ibm-graph profile. I'm not sure that it's strictly part of the IBM-Graph changes to Atlas - it seems to be caused by the org.apache.atlas.repository.impexp package not having a maven dependency on org.apache.solr.common - so ZipFileResourceTestUtils cannot locate StringUtils. - Graham Wallis On May 4, 2017, 4:35 p.m., Apoorv Naik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58803/ > ----------------------------------------------------------- > > (Updated May 4, 2017, 4:35 p.m.) > > > Review request for atlas, David Radley, David Kantor, Graham Wallis, Neeru Gupta, and Jeff Hagelberg. > > > Repository: atlas > > > Description > ------- > > See https://reviews.apache.org/r/56724/ > > Since the review is outdated and lot of conflicting changes have happened over the course of time. This review addresses those conflicts. > > > Diffs > ----- > > common/src/main/java/org/apache/atlas/GraphInitializationException.java PRE-CREATION > common/src/main/java/org/apache/atlas/groovy/LiteralExpression.java 14074994 > common/src/main/java/org/apache/atlas/groovy/VariableAssignmentExpression.java 1aa74435 > distro/pom.xml f0962b6c > distro/src/conf/atlas-application.properties b2b8e745 > distro/src/conf/credentials.json PRE-CREATION > distro/src/main/assemblies/standalone-package.xml 215cb236 > graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraph.java a3a27bfd > graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/GraphDatabase.java 3dfc6e8d > graphdb/graphdb-impls/pom.xml feafe742 > graphdb/ibm-graph/pom.xml PRE-CREATION > graphdb/ibm-graph/readme-multitenancy-support.txt PRE-CREATION > graphdb/ibm-graph/readme.txt PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/AtlasPropertyKeyToPropertyKey.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/ElementDeletedCheckingInvocationHandler.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/GraphPerTenantStrategy.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/GraphReadLockInvocationHandler.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/IBMGraphDatabase.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/IBMGraphEdge.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/IBMGraphElement.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/IBMGraphGraph.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/IBMGraphGraphQuery.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/IBMGraphIndex.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/IBMGraphIndexQuery.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/IBMGraphIndexQueryResult.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/IBMGraphManagement.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/IBMGraphMetadata.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/IBMGraphPropertyKey.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/IBMGraphVertex.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/IBMGraphVertexQuery.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/MultiTenancyDisabledStrategy.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/PartitionPerTenantStrategy.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/TenantGraphStrategy.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/Cardinality.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/GraphDatabaseClient.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/GraphDatabaseConfiguration.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/IGraphDatabaseClient.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/IndexStatus.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/action/AbstractGraphAction.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/action/ClearGraphAction.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/action/ElementIdListPropertyValue.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/action/ElementIdPropertyValue.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/action/GetVertexDataAction.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/action/IGraphAction.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/action/IPropertyValue.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/json/Index.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/json/IndexProperty.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/json/JsonEdge.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/json/JsonErrorResponse.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/json/JsonGraphElement.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/json/JsonGraphInfo.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/json/JsonGremlinQuery.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/json/JsonIndexQueryResult.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/json/JsonNewVertex.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/json/JsonResponse.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/json/JsonVertex.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/json/JsonVertexData.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/json/PropertyDataType.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/json/PropertyKey.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/json/PropertyValue.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/json/Schema.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/json/update/ElementChanges.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/json/update/ElementIdListInfo.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/json/update/ElementProperty.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/json/update/ElementType.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/json/update/NewEdge.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/api/json/update/UpdateScriptBinding.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/exception/BadRequestException.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/exception/GraphDatabaseException.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/exception/HttpException.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/exception/InternalServerException.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/exception/NotFoundException.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/graphson/AtlasElementPropertyConfig.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/graphson/AtlasGraphSONMode.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/graphson/AtlasGraphSONTokens.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/graphson/AtlasGraphSONUtility.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/ActionTranslationContext.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/GremlinQuery.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/QueryElement.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/QueryGenerationResult.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/expr/CollectExpression.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/expr/CreatePartitionExpression.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/expr/DefaultGraphTraversalExpression.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/expr/EvaluableGremlinExpression.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/expr/GetElementExpression.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/expr/GetVertexDataExpression.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/expr/GraphTraversalExpression.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/expr/IndexQueryExpression.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/expr/InstanceOfExpression.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/expr/InterpolatedStringExpression.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/expr/TransformQueryResultExpression.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/expr/TraversalSourceExpression.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/step/AbstractHasStep.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/step/GraphStep.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/step/GremlinEvaluationResult.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/step/GremlinStep.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/step/HasStep.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/step/OrStep.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/step/ToListStep.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/step/VertexStep.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/step/WithinStep.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/stmt/FetchTraversalStatement.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/stmt/ForLoopStatement.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/stmt/IfStatement.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/stmt/ImportStatement.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/stmt/PreGeneratedStatement.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/gremlin/stmt/TryCatchStatement.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/http/HttpCode.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/http/HttpRequest.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/http/HttpRequestDispatcher.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/http/HttpRequestHandler.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/http/HttpResponse.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/http/HttpRetryStrategy.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/http/HttpUtils.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/http/IBMGraphRequestContext.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/http/IHttpRequestDispatcher.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/http/IHttpRetryStrategy.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/http/IdleConnectionMonitorThread.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/http/RequestType.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/tx/DefaultUpdatedEdge.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/tx/DefaultUpdatedGraphElement.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/tx/DefaultUpdatedVertex.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/tx/ElementBackedPropertyMap.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/tx/GraphTransaction.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/tx/IBMGraphTransaction.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/tx/ReadableUpdatedEdge.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/tx/ReadableUpdatedGraphElement.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/tx/ReadableUpdatedVertex.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/tx/UpdatedEdge.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/tx/UpdatedGraphElement.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/tx/UpdatedVertex.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/util/AllowedWhenDeleted.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/util/Batcher.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/util/Endpoint.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/util/FileUtils.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/util/GraphDBUtil.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/util/PersistentType.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/util/PossibleSuccessCase.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/util/PropertyIndex.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/util/PropertyValueToVerticesMap.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/util/SchemaSplitter.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/util/UpdateSchemaRetryStrategy.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/mt/ITenantRegistrationListener.java PRE-CREATION > graphdb/ibm-graph/src/main/java/org/apache/atlas/mt/MultiTenancyConstants.java PRE-CREATION > graphdb/ibm-graph/src/main/resources/graphUpdater.groovy PRE-CREATION > graphdb/ibm-graph/src/test/java/org/apache/atlas/ibmgraph/AbstractGraphDatabaseTest.java PRE-CREATION > graphdb/ibm-graph/src/test/java/org/apache/atlas/ibmgraph/GraphDatabaseQueryTest.java PRE-CREATION > graphdb/ibm-graph/src/test/java/org/apache/atlas/ibmgraph/GraphDatabaseTest.java PRE-CREATION > graphdb/ibm-graph/src/test/java/org/apache/atlas/ibmgraph/GraphQueryTest.java PRE-CREATION > graphdb/ibm-graph/src/test/java/org/apache/atlas/ibmgraph/GraphTransactionTest.java PRE-CREATION > graphdb/ibm-graph/src/test/java/org/apache/atlas/ibmgraph/PropertyDuplicationTest.java PRE-CREATION > graphdb/ibm-graph/src/test/java/org/apache/atlas/ibmgraph/QueryBindingTest.java PRE-CREATION > graphdb/ibm-graph/src/test/java/org/apache/atlas/ibmgraph/SessionCreateTest.java PRE-CREATION > graphdb/ibm-graph/src/test/java/org/apache/atlas/ibmgraph/UpdateScriptLoggingOffTest.java PRE-CREATION > graphdb/ibm-graph/src/test/java/org/apache/atlas/ibmgraph/UpdateScriptLoggingOnTest.java PRE-CREATION > graphdb/ibm-graph/src/test/java/org/apache/atlas/ibmgraph/VertexQueryTest.java PRE-CREATION > graphdb/ibm-graph/src/test/java/org/apache/atlas/ibmgraph/tx/ElementBackedPropertyMapTest.java PRE-CREATION > graphdb/ibm-graph/src/test/java/org/apache/atlas/ibmgraph/tx/TransactionMultiUserTest.java PRE-CREATION > graphdb/ibm-graph/src/test/java/org/apache/atlas/ibmgraph/util/BatcherTest.java PRE-CREATION > graphdb/ibm-graph/src/test/java/org/apache/atlas/ibmgraph/util/PropertyValueToVerticesMapTest.java PRE-CREATION > graphdb/ibm-graph/src/test/java/org/apache/atlas/ibmgraph/util/SchemaSplitterTest.java PRE-CREATION > graphdb/ibm-graph/src/test/resources/atlas-application.properties PRE-CREATION > graphdb/ibm-graph/src/test/resources/atlas-log4j.xml PRE-CREATION > graphdb/ibm-graph/src/test/resources/credentials.json PRE-CREATION > graphdb/ibm-graph/src/test/resources/log4j.xml PRE-CREATION > graphdb/ibm-graph/src/test/resources/update-logging-off-log4j.xml PRE-CREATION > graphdb/ibm-graph/src/test/resources/update-logging-on-log4j.xml PRE-CREATION > graphdb/pom.xml 2112938f > graphdb/src/test/java/org/apache/atlas/graph/GraphSandbox.java PRE-CREATION > graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0Graph.java 9624c99f > graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0GraphDatabase.java 5af90d8c > graphdb/titan0/src/test/java/org/apache/atlas/repository/graphdb/titan0/AbstractGraphDatabaseTest.java 2dca50eb > graphdb/titan0/src/test/java/org/apache/atlas/repository/graphdb/titan0/Titan0DatabaseTest.java ade395be > graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1Graph.java 6a610755 > graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1GraphDatabase.java dfb53545 > graphdb/titan1/src/test/java/org/apache/atlas/repository/graphdb/titan1/AbstractGraphDatabaseTest.java 7f3a436a > graphdb/titan1/src/test/java/org/apache/atlas/repository/graphdb/titan1/Titan1DatabaseTest.java 6db0da83 > pom.xml 934be23c > repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 874487cb > repository/src/main/java/org/apache/atlas/gremlin/Gremlin3ExpressionFactory.java 9f68c9a0 > repository/src/main/java/org/apache/atlas/gremlin/GremlinExpressionFactory.java ff5a58c9 > repository/src/main/java/org/apache/atlas/repository/graph/AtlasGraphProvider.java 0c5cac68 > repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java 47dccf19 > repository/src/main/java/org/apache/atlas/repository/graph/IAtlasGraphProvider.java a2cac2df > repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java c3e25bda > repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java 2f298ba4 > repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java e873e91b > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityDefStoreV1.java 1bfe3b90 > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEnumDefStoreV1.java 39c4dd93 > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java 560b3385 > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java b76dfefa > repository/src/main/java/org/apache/atlas/util/AtlasGremlinQueryProvider.java 8fb1793e > repository/src/main/scala/org/apache/atlas/query/GraphPersistenceStrategies.scala 752a522c > repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala 3a310a77 > repository/src/test/java/org/apache/atlas/BaseRepositoryTest.java 6656dc67 > repository/src/test/java/org/apache/atlas/RepositoryServiceLoadingTest.java 6e13077e > repository/src/test/java/org/apache/atlas/TestMetadataModule.java PRE-CREATION > repository/src/test/java/org/apache/atlas/TestUtils.java f09aa5ac > repository/src/test/java/org/apache/atlas/discovery/DataSetLineageServiceTest.java da2b4426 > repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java f3fdf085 > repository/src/test/java/org/apache/atlas/lineage/EntityLineageServiceTest.java 6a1979a0 > repository/src/test/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepositoryTest.java a9dfee33 > repository/src/test/java/org/apache/atlas/repository/graph/AbstractGremlinQueryOptimizerTest.java 2dda8536 > repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java f0424ab9 > repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryTest.java 9f32b853 > repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexerTest.java 1716ac53 > repository/src/test/java/org/apache/atlas/repository/graph/GraphHelperTest.java 38319201 > repository/src/test/java/org/apache/atlas/repository/graph/GraphRepoMapperScaleTest.java a2fffe7a > repository/src/test/java/org/apache/atlas/repository/graph/ReverseReferenceUpdateTestBase.java b87f7fd9 > repository/src/test/java/org/apache/atlas/repository/graph/TestIntSequence.java b8eefca1 > repository/src/test/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStoreTest.java 84ad72c8 > repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasDeleteHandlerV1Test.java f1c4e48f > repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java acb80754 > repository/src/test/java/org/apache/atlas/repository/typestore/GraphBackedTypeStoreTest.java 732a3821 > repository/src/test/java/org/apache/atlas/repository/typestore/StoreBackedTypeCacheTest.java 6c6c959e > repository/src/test/java/org/apache/atlas/repository/typestore/StoreBackedTypeCacheTestModule.java a1d7a745 > repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java 2b72f2a1 > repository/src/test/resources/credentials.json PRE-CREATION > repository/src/test/scala/org/apache/atlas/query/GremlinTest.scala acc70b5e > repository/src/test/scala/org/apache/atlas/query/LineageQueryTest.scala bb44686c > typesystem/src/test/resources/atlas-application.properties 5ffde5e5 > typesystem/src/test/resources/credentials.json PRE-CREATION > webapp/pom.xml 28bd7ea6 > webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java 473c78df > webapp/src/test/java/org/apache/atlas/web/TestUtils.java e22a1c10 > webapp/src/test/java/org/apache/atlas/web/adapters/TestEntitiesREST.java 7badd1e6 > webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java f079d631 > webapp/src/test/java/org/apache/atlas/web/listeners/TestGuiceServletConfig.java da221fc1 > webapp/src/test/java/org/apache/atlas/web/listeners/TestModule.java b00080f1 > webapp/src/test/java/org/apache/atlas/web/resources/DataSetLineageJerseyResourceIT.java ee4057d4 > webapp/src/test/java/org/apache/atlas/web/resources/EntityLineageJerseyResourceIT.java 4f8badf1 > webapp/src/test/java/org/apache/atlas/web/resources/EntityResourceTest.java 21060d14 > webapp/src/test/java/org/apache/atlas/web/resources/MetadataDiscoveryJerseyResourceIT.java 87d8719f > webapp/src/test/java/org/apache/atlas/web/service/SecureEmbeddedServerTest.java dc3b936b > webapp/src/test/java/org/apache/atlas/web/service/SecureEmbeddedServerTestBase.java 5d4ca972 > > > Diff: https://reviews.apache.org/r/58803/diff/2/ > > > Testing > ------- > > See https://reviews.apache.org/r/56724/ > > > Thanks, > > Apoorv Naik > > --===============5967993616492698290==--