Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 5AF25200C7D for ; Tue, 2 May 2017 02:00:38 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 59876160BC2; Tue, 2 May 2017 00:00:38 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 9FBFC160BC1 for ; Tue, 2 May 2017 02:00:37 +0200 (CEST) Received: (qmail 50572 invoked by uid 500); 2 May 2017 00:00:36 -0000 Mailing-List: contact dev-help@atlas.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@atlas.incubator.apache.org Delivered-To: mailing list dev@atlas.incubator.apache.org Received: (qmail 50561 invoked by uid 99); 2 May 2017 00:00:36 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 May 2017 00:00:36 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 3554C1B14CE; Tue, 2 May 2017 00:00:36 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 4.201 X-Spam-Level: **** X-Spam-Status: No, score=4.201 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 5Fj6hcUiS4WM; Tue, 2 May 2017 00:00:35 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 7AD165F5F9; Tue, 2 May 2017 00:00:34 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id C6B53E0045; Tue, 2 May 2017 00:00:33 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 86178C40019; Tue, 2 May 2017 00:00:33 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7232429374942839534==" MIME-Version: 1.0 Subject: Re: Review Request 58746: Type validations with special character handling From: Apoorv Naik To: Ashutosh Mestry , Madhan Neethiraj , Sarath Subramanian Cc: Apoorv Naik , atlas Date: Tue, 02 May 2017 00:00:33 -0000 Message-ID: <20170502000033.62744.5501@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Apoorv Naik X-ReviewGroup: atlas X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/58746/ X-Sender: Apoorv Naik References: <20170501235626.62744.57716@reviews-vm2.apache.org> In-Reply-To: <20170501235626.62744.57716@reviews-vm2.apache.org> Reply-To: Apoorv Naik X-ReviewRequest-Repository: atlas archived-at: Tue, 02 May 2017 00:00:38 -0000 --===============7232429374942839534== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58746/ ----------------------------------------------------------- (Updated May 2, 2017, midnight) Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath Subramanian, and Suma Shivaprasad. Changes ------- Adding the tests back Bugs: ATLAS-1730, ATLAS-1736 and ATLAS-1747 https://issues.apache.org/jira/browse/ATLAS-1730 https://issues.apache.org/jira/browse/ATLAS-1736 https://issues.apache.org/jira/browse/ATLAS-1747 Repository: atlas Description ------- 1. Added empty attribute(s) check 2. Dealing with special characters like $,%,{,} (titan treats these specially) 3. Update of attribute type is not allowed anymore Diffs (updated) ----- repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java 6f1b80c8 repository/src/main/java/org/apache/atlas/repository/typestore/GraphBackedTypeStore.java 7037d1eb repository/src/test/java/org/apache/atlas/repository/typestore/GraphBackedTypeStoreTest.java c08bb881 Diff: https://reviews.apache.org/r/58746/diff/5/ Changes: https://reviews.apache.org/r/58746/diff/4-5/ Testing ------- mvn clean package executes successfully Thanks, Apoorv Naik --===============7232429374942839534==--