Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id E9138200C77 for ; Mon, 1 May 2017 08:43:55 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id E7A06160BAE; Mon, 1 May 2017 06:43:55 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 3B265160BAB for ; Mon, 1 May 2017 08:43:55 +0200 (CEST) Received: (qmail 59131 invoked by uid 500); 1 May 2017 06:43:54 -0000 Mailing-List: contact dev-help@atlas.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@atlas.incubator.apache.org Delivered-To: mailing list dev@atlas.incubator.apache.org Received: (qmail 59120 invoked by uid 99); 1 May 2017 06:43:53 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 May 2017 06:43:53 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 934DCD7AF8; Mon, 1 May 2017 06:43:53 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.999 X-Spam-Level: ** X-Spam-Status: No, score=2.999 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 1M6v3i3cDWGQ; Mon, 1 May 2017 06:43:52 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id E977D60DA2; Mon, 1 May 2017 06:43:51 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 16F2DE002F; Mon, 1 May 2017 06:43:50 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id A01B9C40967; Mon, 1 May 2017 06:43:50 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7143017970825491605==" MIME-Version: 1.0 Subject: Re: Review Request 58746: ATLAS-1736: Type validations with special character handling From: Madhan Neethiraj To: Madhan Neethiraj , Apoorv Naik , atlas Date: Mon, 01 May 2017 06:43:50 -0000 Message-ID: <20170501064350.30738.55774@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Madhan Neethiraj X-ReviewGroup: atlas X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/58746/ X-Sender: Madhan Neethiraj References: <20170428162502.16779.86977@reviews-vm2.apache.org> In-Reply-To: <20170428162502.16779.86977@reviews-vm2.apache.org> Reply-To: Madhan Neethiraj X-ReviewRequest-Repository: atlas archived-at: Mon, 01 May 2017 06:43:56 -0000 --===============7143017970825491605== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58746/#review173463 ----------------------------------------------------------- repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java Lines 437 (patched) if attributeDef is a new attribute, currentStructDef.getAttribute(attributeDef.getName()) will return null and .getTypeName() on the return value will be NPE. Can you please review? - Madhan Neethiraj On April 28, 2017, 4:25 p.m., Apoorv Naik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58746/ > ----------------------------------------------------------- > > (Updated April 28, 2017, 4:25 p.m.) > > > Review request for atlas. > > > Bugs: ATLAS-1730 and ATLAS-1736 > https://issues.apache.org/jira/browse/ATLAS-1730 > https://issues.apache.org/jira/browse/ATLAS-1736 > > > Repository: atlas > > > Description > ------- > > Added empty attribute(s) check and dealing with special characters like $,%,{,} (reserved for special titan) > > > Diffs > ----- > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java f154555b > repository/src/main/java/org/apache/atlas/repository/typestore/GraphBackedTypeStore.java 7037d1eb > repository/src/test/java/org/apache/atlas/repository/typestore/GraphBackedTypeStoreTest.java c08bb881 > > > Diff: https://reviews.apache.org/r/58746/diff/2/ > > > Testing > ------- > > mvn clean package executes successfully > > > Thanks, > > Apoorv Naik > > --===============7143017970825491605==--