atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Radley (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ATLAS-1410) V2 Glossary API
Date Thu, 25 May 2017 17:19:04 GMT

    [ https://issues.apache.org/jira/browse/ATLAS-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16025052#comment-16025052
] 

David Radley commented on ATLAS-1410:
-------------------------------------

[~mandy_chessell] Looks really good. Some thoughts: 

- 210 I wonder if language should be a code table value - or more generally an valid value
from reference data   
-210 I am wondering about usage. Should this also be a code table - it seems more structural
than the description 
-220 I suggest the supercategory to the subcategory be a composition (filled in diamond) relationship.
 
- 230 I think the GlossaryCategory role name should be categories rather than category 
- 240 I wonder about the "to" and "from" ends of the related term as they imply a direction
- for a SYNONYM and TRANSLATION there is no direction. It is almost like synonyms and transactions
should be in a synonym group or translation group respectively. Maybe we introduce an equivalence
group concept, where everything in the group is related to everything else in the group. This
would help for tag propagation for these terms.    

I don't think we have a way in the current Atlas model to constrain the number of classifications
to  0..1. 

> V2 Glossary API
> ---------------
>
>                 Key: ATLAS-1410
>                 URL: https://issues.apache.org/jira/browse/ATLAS-1410
>             Project: Atlas
>          Issue Type: Improvement
>            Reporter: David Radley
>            Assignee: David Radley
>         Attachments: Atlas Glossary V2 proposal v1.0.pdf, Atlas Glossary V2 proposal
v1.1.pdf, Atlas Glossary V2 proposal v1.2.pdf, Atlas Glossary V2 proposal v1.3.pdf, Atlas
Glossary V2 proposal v1.4.pdf
>
>
> The BaseResourceDefinition uses the AttributeDefintion class from typesystem. There are
newer more funcitonal versions of this capability in the atlas-intg project. This Jira is
changing over the glossary implementation to the newer entity / type classes.  
> Instread of the instanceProperties and collectionProperties in the BaseResourceDefintions
we should use something in this sort of style :  
> "
>  AtlasEntityDef deptTypeDef =
>                 AtlasTypeUtil.createClassTypeDef(DEPARTMENT_TYPE, "Department"+_description,
ImmutableSet.<String>of(),
>                         AtlasTypeUtil.createRequiredAttrDef("name", "string"),
>                         new AtlasAttributeDef("employees", String.format("array<%s>",
"Person"), true,
>                                 AtlasAttributeDef.Cardinality.SINGLE, 0, 1, false, false,
>                                 Collections.<AtlasStructDef.AtlasConstraintDef>emptyList()));
>         AtlasEntityDef personTypeDef = AtlasTypeUtil.createClassTypeDef("Person", "Person"+_description,
ImmutableSet.<String>of(),
>                 AtlasTypeUtil.createRequiredAttrDef("name", "string"),
>                 AtlasTypeUtil.createOptionalAttrDef("address", "Address"),
>                 AtlasTypeUtil.createOptionalAttrDef("birthday", "date"),
>                 AtlasTypeUtil.createOptionalAttrDef("hasPets", "boolean"),
>                 AtlasTypeUtil.createOptionalAttrDef("numberOfCars", "byte"),
>                 AtlasTypeUtil.createOptionalAttrDef("houseNumber", "short"),
>                 AtlasTypeUtil.createOptionalAttrDef("carMileage", "int"),
>                 AtlasTypeUtil.createOptionalAttrDef("age", "float"),
> "
> For the parent child relationships with glossary categories and terms we should be able
to have the type system manage edge deletion. As part of this, we will need to investigate
whether we could get rid of the disconnect and connect methods added in ATLAS-1186 
>  



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message