atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sarath Subramanian <sar...@apache.org>
Subject Re: Review Request 59533: Test Sandbox fix
Date Wed, 24 May 2017 17:45:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59533/#review175961
-----------------------------------------------------------




graphdb/common/src/test/java/org/apache/atlas/graph/GraphSandboxUtil.java
Line 40 (original), 41 (patched)
<https://reviews.apache.org/r/59533/#comment249311>

    can you consider appending UUID with storage/index directory. It should be unique across
forked process.


- Sarath Subramanian


On May 24, 2017, 10:30 a.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59533/
> -----------------------------------------------------------
> 
> (Updated May 24, 2017, 10:30 a.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, and Suma Shivaprasad.
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Due to race condition, a couple of test still end up using the same directory for DB/index
storage. 
> 
> This change checks for the existence of the folder and generates the name again in case
of any discrepancy.
> 
> 
> Diffs
> -----
> 
>   graphdb/common/src/test/java/org/apache/atlas/graph/GraphSandboxUtil.java 44ad4fc0

> 
> 
> Diff: https://reviews.apache.org/r/59533/diff/1/
> 
> 
> Testing
> -------
> 
> mvn clean package executes successfully
> mvn clean install executes successfully with one consitent failure related to notification
processing.
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message