atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Hentschel <jan.hentsc...@ultratendency.com>
Subject Re: Review Request 59264: ATLAS-1787: Replace explicit type with diamond operator
Date Mon, 15 May 2017 16:25:47 GMT


> On May 15, 2017, 6:08 p.m., Apoorv Naik wrote:
> > Looks good overall, can you also cover the test clasess for consistency ?

The test classes should already be covered. I couldn't find any other places (including the
test classes) which are using the diamond operator. Do you have a specific test class in mind?


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59264/#review174961
-----------------------------------------------------------


On May 14, 2017, 6:58 p.m., Jan Hentschel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59264/
> -----------------------------------------------------------
> 
> (Updated May 14, 2017, 6:58 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1787
>     https://issues.apache.org/jira/browse/ATLAS-1787
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Replaced the remaining places where explicit types are used.
> 
> 
> Diffs
> -----
> 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1Graph.java
6a61075 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1GraphIndex.java
5ec1180 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1Vertex.java
1670e92 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/graphson/AtlasElementPropertyConfig.java
df67a83 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/graphson/AtlasGraphSONUtility.java
26abe2e 
>   graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/serializer/StringListSerializer.java
eb99fae 
>   graphdb/titan1/src/test/java/org/apache/atlas/repository/graphdb/titan1/GraphQueryTest.java
45fbbea 
>   graphdb/titan1/src/test/java/org/apache/atlas/repository/graphdb/titan1/Titan1DatabaseTest.java
ab2c8c9 
>   intg/src/test/java/org/apache/atlas/type/TestAtlasObjectIdType.java fb4a183 
>   repository/src/main/java/org/apache/atlas/gremlin/optimizer/ExpandOrsOptimization.java
a48a007 
>   repository/src/main/java/org/apache/atlas/repository/converters/TypeConverterUtil.java
7902100 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java
d1e8cb7 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java ca7fad0

>   repository/src/main/java/org/apache/atlas/repository/typestore/GraphBackedTypeStore.java
ac13586 
>   repository/src/main/java/org/apache/atlas/repository/typestore/TypeVertexFinder.java
8b38152 
>   repository/src/main/java/org/apache/atlas/util/AtlasRepositoryConfiguration.java a4a596a

>   repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java
18573fc 
>   repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java
1dd7276 
>   webapp/src/main/java/org/apache/atlas/web/security/AtlasAbstractAuthenticationProvider.java
e55d2cf 
> 
> 
> Diff: https://reviews.apache.org/r/59264/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jan Hentschel
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message