atlas-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nixon Rodrigues <nixon.rodrig...@freestoneinfotech.com>
Subject Re: Review Request 59171: ATLAS-1776- Include historical entities in UI : A query is made and cancelled every time the check box is checked/unchecked showing "Invalid expression:null" notification / ATLAS-1777 - UI : Include historical entities check box is not shown when searching a type with all DELETED entities, hence no
Date Thu, 11 May 2017 10:35:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59171/#review174631
-----------------------------------------------------------


Ship it!




Ship It!

- Nixon Rodrigues


On May 11, 2017, 10:07 a.m., Kalyani Kashikar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59171/
> -----------------------------------------------------------
> 
> (Updated May 11, 2017, 10:07 a.m.)
> 
> 
> Review request for atlas, keval bhatt, Madhan Neethiraj, and Nixon Rodrigues.
> 
> 
> Bugs: ATLAS-1776 and ATLAS-1777
>     https://issues.apache.org/jira/browse/ATLAS-1776
>     https://issues.apache.org/jira/browse/ATLAS-1777
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> ATLAS-1776 patch contains fix for Invalid expression :null' notification when check box
is checked/unchecked. 
> And also same patch contains fix for ATLAS-1777 i.e checkbox is always showing whether
the search result data is there or not.
> 
> 
> Diffs
> -----
> 
>   dashboardv2/public/css/scss/override.scss 38e120f 
>   dashboardv2/public/js/templates/search/SearchResultLayoutView_tmpl.html 4361ca1 
>   dashboardv2/public/js/views/search/SearchResultLayoutView.js b2f24d4 
> 
> 
> Diff: https://reviews.apache.org/r/59171/diff/1/
> 
> 
> Testing
> -------
> 
> Verified 'Invalid expression :null' notification is not shown when check box is checked/unchecked.
> Verified checkbox is always showing whether the search result data is there or not.
> Verified on Click of label beside checkbox shows loader on click.
> 
> 
> Thanks,
> 
> Kalyani Kashikar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message